r100293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100292‎ | r100293 | r100294 >
Date:23:31, 19 October 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Hack out default for submission count

Fixes bug 31833
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/Contest/includes/Contest.class.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/Contest/includes/Contest.class.php
——@@ -150,7 +150,7 @@
151151 'signup_email' => $defaultPage,
152152 'reminder_email' => $defaultPage,
153153
154 - 'submission_count' => 0,
 154+// 'submission_count' => 0,
155155 );
156156 }
157157

Follow-up revisions

RevisionCommit summaryAuthorDate
r100295fix bug 31833jeroendedauw23:39, 19 October 2011
r100298Revert r100293 live hackreedy23:54, 19 October 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   23:33, 19 October 2011

This will cause problems when creating new contests I think. Not sure. Either way, I'll look for a better fix now.

#Comment by Reedy (talk | contribs)   23:36, 19 October 2011

Nope, it doesn't, I just tried it.

NOT NULL on a numeric type, it seems MySQL (at least) is happy and just sets it to 0

If you want to fix it properly, that is fine

#Comment by Jeroen De Dauw (talk | contribs)   23:40, 19 October 2011

Done so in r100295

Status & tagging log