r100190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100189‎ | r100190 | r100191 >
Date:23:58, 18 October 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix typo

Trim trailing whitespace
Modified paths:
  • /trunk/extensions/Contest/Contest.settings.php (modified) (history)
  • /trunk/extensions/Contest/test/ContestValidationTests.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/test/ContestValidationTests.php
@@ -33,8 +33,8 @@
3434 'https://gitorious.org/statusnet/mainline/merge_requests/2224' => true,
3535 );
3636
37 - foreach ( $tests as $test => $isValdid ) {
38 - if ( $isValdid ) {
 37+ foreach ( $tests as $test => $isValid ) {
 38+ if ( $isValid ) {
3939 $this->assertEquals( true, SpecialMyContests::validateSubmissionField( $test ) );
4040 }
4141 else {
Index: trunk/extensions/Contest/Contest.settings.php
@@ -21,9 +21,9 @@
2222 /**
2323 * Returns the default values for the settings.
2424 * setting name (string) => setting value (mixed)
25 - *
 25+ *
2626 * @since 0.1
27 - *
 27+ *
2828 * @return array
2929 */
3030 protected static function getDefaultSettings() {
@@ -39,9 +39,9 @@
4040 * Retruns an array with all settings after making sure they are
4141 * initialized (ie set settings have been merged with the defaults).
4242 * setting name (string) => setting value (mixed)
43 - *
 43+ *
4444 * @since 0.1
45 - *
 45+ *
4646 * @return array
4747 */
4848 public static function getSettings() {
@@ -59,21 +59,21 @@
6060
6161 /**
6262 * Gets the value of the specified setting.
63 - *
 63+ *
6464 * @since 0.1
65 - *
 65+ *
6666 * @param string $settingName
67 - *
 67+ *
6868 * @throws MWException
6969 * @return mixed
7070 */
7171 public static function get( $settingName ) {
7272 $settings = self::getSettings();
73 -
 73+
7474 if ( !array_key_exists( $settingName, $settings ) ) {
7575 throw new MWException( 'Attempt to get non-existing setting "' . $settingName . '"' );
7676 }
77 -
 77+
7878 return $settings[$settingName];
7979 }
8080

Follow-up revisions

RevisionCommit summaryAuthorDate
r1001951.18wmf1 MFT r100190, r100191, r100193reedy00:41, 19 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99285added testjeroendedauw00:04, 8 October 2011

Comments

#Comment by Hashar (talk | contribs)   13:04, 6 December 2011

follow up r99285

Status & tagging log