r100187 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100186‎ | r100187 | r100188 >
Date:23:46, 18 October 2011
Author:johnduhart
Status:ok (Comments)
Tags:
Comment:
Followup r100165 and r100186: Formatting, requirement change, and removing mistakenly placed comma
Modified paths:
  • /trunk/extensions/CheckUser/api/ApiQueryCheckUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/api/ApiQueryCheckUser.php
@@ -213,11 +213,11 @@
214214 ApiBase::PARAM_TYPE => array(
215215 'userips',
216216 'edits',
217 - 'ipusers'
 217+ 'ipusers',
218218 )
219219 ),
220220 'target' => array(
221 - ApiBase::PARAM_REQUIRED => false
 221+ ApiBase::PARAM_REQUIRED => true,
222222 ),
223223 'reason' => null,
224224 'limit' => array(
@@ -225,9 +225,9 @@
226226 ApiBase::PARAM_TYPE => 'limit',
227227 ApiBase::PARAM_MIN => 1,
228228 ApiBase::PARAM_MAX => 5000,
229 - ApiBase::PARAM_MAX2 => 5000
 229+ ApiBase::PARAM_MAX2 => 5000,
230230 ),
231 - 'timecond' => null
 231+ 'timecond' => null,
232232 );
233233 }
234234

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100165Adds API Module by cryptocoryne...johnduhart21:37, 18 October 2011
r100186Followup r100165, fixing formatting per CRjohnduhart23:41, 18 October 2011

Comments

#Comment by Johnduhart (talk | contribs)   23:48, 18 October 2011

"removing mistakenly placed comma" r100188, ugh.

Status & tagging log