r100097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100096‎ | r100097 | r100098 >
Date:22:57, 17 October 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Fix svn props, r99919
Modified paths:
  • /trunk/phase3/maintenance/benchmarks/benchmarkHooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/benchmarks/benchmarkHooks.php
@@ -25,7 +25,7 @@
2626
2727 public function __construct() {
2828 parent::__construct();
29 - $this->mDescription = "Benchmark MediaWiki Hooks.";
 29+ $this->mDescription = 'Benchmark MediaWiki Hooks.';
3030 }
3131
3232 public function execute() {
@@ -76,5 +76,5 @@
7777 }
7878 }
7979
80 -$maintClass = "BenchmarkHooks";
 80+$maintClass = 'BenchmarkHooks';
8181 require_once( RUN_MAINTENANCE_IF_MAIN );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99919Rudimentary hook benchmarksreedy22:15, 15 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:49, 18 October 2011

Wrong message or wrong file?

#Comment by Krinkle (talk | contribs)   16:59, 18 October 2011

I didn't mention in the message that I changed double quotes to single quotes. I did however set the propset, but r99939 was already committed (I hadn't up'ed that one yet) and it magically merged..

Status & tagging log