r100003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100002‎ | r100003 | r100004 >
Date:23:03, 16 October 2011
Author:nelson
Status:ok (Comments)
Tags:
Comment:
StoreBatchTest counts even MORE correct than before.
Modified paths:
  • /trunk/phase3/includes/filerepo/FSRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FSRepo.php
@@ -220,9 +220,11 @@
221221 $hashDest = sha1_file( $dstPath );
222222 if ( $hashSource != $hashDest ) {
223223 $status->fatal( 'fileexistserror', $dstPath );
 224+ $status->failCount++;
224225 }
225226 } else {
226227 $status->fatal( 'fileexistserror', $dstPath );
 228+ $status->failCount++;
227229 }
228230 }
229231 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99984StoreBatchTest counts now correct, and using assertEqualsnelson22:18, 16 October 2011

Comments

#Comment by RussNelson (talk | contribs)   23:05, 16 October 2011

Fixes r99984

Status & tagging log