r99854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99853‎ | r99854 | r99855 >
Date:08:59, 15 October 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
install++ and param stype fix
Modified paths:
  • /trunk/extensions/SemanticResultFormats/INSTALL (modified) (history)
  • /trunk/extensions/SemanticResultFormats/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/RELEASE-NOTES
@@ -2,6 +2,11 @@
33 http://semantic-mediawiki.org/wiki/Semantic_Result_Formats
44
55
 6+== SRF 1.7 ==
 7+
 8+* Compatibility with SMW 1.7 and later.
 9+* Dropped support for MediaWiki 1.15.x.
 10+
611 == SRF 1.6.2 ==
712
813 Released on September 18, 2011.
Index: trunk/extensions/SemanticResultFormats/INSTALL
@@ -1,3 +1,15 @@
 2+== Requirements ==
 3+
 4+Semantic Result Formats requires:
 5+* MediaWiki 1.16 or above
 6+* Semantic MediaWiki 1.7 or above
 7+* PHP 5.2 or above
 8+
 9+For older setups, SRF 1.6.x can be used, which has these requirements:
 10+* MediaWiki 1.15 or above
 11+* Semantic MediaWiki 1.5.1 to 1.6.1
 12+* PHP 5.2 or above
 13+
214 == Installation ==
315
416 Installation instructions are available online in a more convenient form for
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php
@@ -172,7 +172,8 @@
173173 $params['height'] = new Parameter( 'height', Parameter::TYPE_INTEGER, 400 );
174174 $params['height']->setMessage( 'srf_paramdesc_chartheight' );
175175
176 - $params['width'] = new Parameter( 'width', Parameter::TYPE_INTEGER, 400 );
 176+ // TODO: this is a string to allow for %, but better handling would be nice
 177+ $params['width'] = new Parameter( 'width', Parameter::TYPE_STRING, '400' );
177178 $params['width']->setMessage( 'srf_paramdesc_chartwidth' );
178179
179180 $params['charttitle'] = new Parameter( 'charttitle', Parameter::TYPE_STRING, ' ' );
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php
@@ -274,7 +274,8 @@
275275 $params['height'] = new Parameter( 'height', Parameter::TYPE_INTEGER, 400 );
276276 $params['height']->setMessage( 'srf_paramdesc_chartheight' );
277277
278 - $params['width'] = new Parameter( 'width', Parameter::TYPE_INTEGER, 150 );
 278+ // TODO: this is a string to allow for %, but better handling would be nice
 279+ $params['width'] = new Parameter( 'width', Parameter::TYPE_STRING, '100%' );
279280 $params['width']->setMessage( 'srf_paramdesc_chartwidth' );
280281
281282 $params['charttitle'] = new Parameter( 'charttitle', Parameter::TYPE_STRING, ' ' );