r99764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99763‎ | r99764 | r99765 >
Date:12:55, 14 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Followup r99762 - no point adding continue tag if offset is not handled :)
Modified paths:
  • /trunk/extensions/Translate/api/ApiQueryMessageTranslations.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/api/ApiQueryMessageTranslations.php
@@ -66,6 +66,9 @@
6767 $count = 0;
6868
6969 foreach ( $pageInfo as $key => $info ) {
 70+ if ( ++$count <= $params['offset'] ) {
 71+ continue;
 72+ }
7073
7174 $tTitle = Title::makeTitle( $namespace, $key );
7275 $tHandle = new MessageHandle( $tTitle );
@@ -87,7 +90,7 @@
8891
8992 $fit = $result->addValue( array( 'query', $this->getModuleName() ), null, $data );
9093 if ( !$fit ) {
91 - $this->setContinueEnumParameter( 'offset', $params['offset'] + $count - 1 );
 94+ $this->setContinueEnumParameter( 'offset', $count );
9295 break;
9396 }
9497

Follow-up revisions

RevisionCommit summaryAuthorDate
r100004MFT r99673: possible fix for bug 31653: Translation page updates might not ha...siebrand23:12, 16 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99762New API module: messagetranslationsnikerabbit09:54, 14 October 2011

Status & tagging log