r99756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99755‎ | r99756 | r99757 >
Date:07:23, 14 October 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
Makefile changed. 0.944 improved the Makefile by adding a test if patch (program) exists. Some users reported that patch program is installed by default in all Linux distributions like Ubuntu
Modified paths:
  • /trunk/extensions/OpenID/Makefile (modified) (history)
  • /trunk/extensions/OpenID/OpenID.php (modified) (history)
  • /trunk/extensions/OpenID/README.OpenID-mediawiki-extension (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/README.OpenID-mediawiki-extension
@@ -1,5 +1,5 @@
22 MediaWiki OpenID extension README.OpenID-mediawiki-extension file
3 -version 0.941-beta 20111011
 3+version 0.944-beta 20111014
44
55 Homepage and manual http://www.mediawiki.org/wiki/Extension:OpenID
66
@@ -467,6 +467,8 @@
468468 into that account now
469469
470470 == CHANGES ==
 471+* 0.944 improved the Makefile by adding a test if "patch" (program) exists
 472+ some users reported that this is not standard in all distrubtions
471473 * 0.942 code cosmetic db schema updater
472474 * 0.940 changed database schema updater; tested for MySQL
473475 * 0.939 function name changes
Index: trunk/extensions/OpenID/OpenID.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.943-beta 20111013' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.944-beta 20111014' );
3232
3333 $path = dirname( __FILE__ );
3434 set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );
Index: trunk/extensions/OpenID/Makefile
@@ -1,31 +1,65 @@
22 VER=2.2.2
33 SUBDIR=openid-php-openid-782224d
 4+SHELL = /bin/sh
 5+
46 # how to make that one predictable easily?
57
68 # http://www.mediawiki.org/wiki/Extension:OpenID
79 #
810 # This makefile automates the installation of a prerequisite for the MediaWiki OpenID extension.
911 #
10 -# First download the extension which includes this makefile from
11 -# http://www.mediawiki.org/wiki/Special:ExtensionDistributor/OpenID
 12+# MediaWiki OpenID extensions depends on the
 13+# OpenIDEnabled.com PHP library for OpenID which in turn depends on the
 14+# OpenIDEnabled.com PHP library for YADIS.
1215 #
13 -# MediaWiki OpenID depends on the OpenIDEnabled.com PHP library for OpenID,
14 -# which in turn depends on the OpenIDEnabled.com PHP library for YADIS.
 16+# STEP 1:
 17+# Get the extension by method (a) or (b) or (c).
1518 #
16 -# Installation:
 19+# (a) First download the MediaWiki OpenID extension which includes this makefile from
 20+# http://www.mediawiki.org/wiki/Special:ExtensionDistributor/OpenID
1721 #
18 -# cd $IP/extensions/OpenID
19 -# make
 22+# or by checking out from SVN as explained in (b) or (c)
2023 #
 24+# (b) anonymous users checkout using this command:
 25+# cd $IP/extensions
 26+# svn checkout svn://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/OpenID OpenID
 27+#
 28+# (c) developers however checkout using this command:
 29+# cd $IP/extensions
 30+# svn checkout svn+ssh://USERNAME@svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/OpenID OpenID
 31+#
 32+# STEP 2
2133 # The makefile downloads the openid-php library from http://www.openidenabled.com/php-openid/
2234 # and applies a patch to avoid PHP errors because Call-time pass-by-reference is deprecated
2335 # since PHP 5.3.x see https://github.com/openid/php-openid/issues#issue/8 and
2436 # the patch and fork of user kost https://github.com/openid/php-openid/pull/44/files
2537 #
26 -# T. Gries 20110203
 38+# Go to the extensions/OpenID subdirectors and start the installation
 39+# which also downloads and patches the pre-requisites:
 40+#
 41+# cd $IP/extensions/OpenID
 42+# make
 43+#
 44+# initially written by Brion Vibber
 45+# 20110203 T. Gries
 46+# 20111014 added a test whether "patch" (program) exists before starting it blindly
2747
28 -php-openid: Auth
 48+install: check-if-patch-exists Auth
2949
 50+# test if "patch" program is installed
 51+# some distributions don't have it installed by default
 52+# alternative rule: patch-exists: ; patch --version >/dev/null
 53+# http://www.gnu.org/s/hello/manual/make/Standard-Targets.html
 54+
 55+check-if-patch-exists:
 56+ @if $(SHELL) -c 'which patch' >/dev/null 2>&1; then \
 57+ # echo "...The 'patch' program exists." ; \
 58+ true; \
 59+ else \
 60+ echo "...The 'patch' program does not exist on your system. Please install it before running make."; \
 61+ false; \
 62+ fi
 63+
3064 Auth: php-openid-$(VER).tar.gz
3165 tar -xzf php-openid-$(VER).tar.gz $(SUBDIR)/Auth
3266 rm -f php-openid-$(VER).tar.gz

Status & tagging log