r99729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99728‎ | r99729 | r99730 >
Date:20:35, 13 October 2011
Author:preilly
Status:ok
Tags:
Comment:
Reverting previous commit and going back to revision 99727
Modified paths:
  • /trunk/extensions/MobileFrontend (modified) (history)
  • /trunk/extensions/MobileFrontend/MobileFrontend.i18n.php (modified) (history)
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/application.js (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/application.js
@@ -3,14 +3,6 @@
44
55 initClearSearchLink();
66
7 -function goToLanguageSelection() {
8 - var languageSelection = document.getElementById( 'languageselection' );
9 - var newlocation = languageSelection.options[languageSelection.selectedIndex].value;
10 - if ( newlocation ) {
11 - window.location = newlocation;
12 - }
13 -}
14 -
157 function initClearSearchLink() {
168 clearSearch.setAttribute( 'title','Clear' );
179 clearSearch.addEventListener( 'mousedown', clearSearchBox, true );
Index: trunk/extensions/MobileFrontend/MobileFrontend.i18n.php
@@ -68,7 +68,6 @@
6969 'mobile-frontend-leave-feedback' => 'Mobile site feedback',
7070 'mobile-frontend-feedback-page' => 'Project:Mobile Extension Feedback',
7171 'mobile-frontend-leave-feedback-thanks' => 'Thanks, for your feedback!',
72 - 'mobile-frontend-language-selection' => 'Languages',
7372 );
7473
7574 /** Message documentation (Message documentation)
Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -1018,7 +1018,7 @@
10191019 } elseif ( $this->contentFormat == 'WML' ) {
10201020 $homeButton = self::$messages['mobile-frontend-home-button'];
10211021 $randomButton = self::$messages['mobile-frontend-random-button'];
1022 - //header( 'Content-Type: text/vnd.wap.wml' );
 1022+ header( 'Content-Type: text/vnd.wap.wml' );
10231023
10241024 // TODO: Content transformations required
10251025 // WML Validator:
Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -6,12 +6,9 @@
77 $randomPageUrl = self::$randomPageUrl;
88 $homeButton = self::$messages['mobile-frontend-home-button'];
99 $randomButton = self::$messages['mobile-frontend-random-button'];
10 -$languageSelectionText = self::$messages['mobile-frontend-language-selection'];
1110
1211 $scriptUrl = wfScript();
1312
14 -$languageSelection = self::buildLanguageSelection();
15 -
1613 $searchWebkitHtml = <<<EOD
1714 <div id='header'>
1815 <div id='searchbox'>
@@ -24,14 +21,10 @@
2522 </div>
2623 <button id='goButton' type='submit'></button>
2724 </form>
28 - <div id='results'></div>
2925 </div>
3026 <div class='nav' id='nav'>
3127 <form method="get" action="{$mainPageUrl}"><button type="submit" id="homeButton">{$homeButton}</button></form>
3228 <form method="get" action="{$randomPageUrl}"><button type="submit" id="randomButton">{$randomButton}</button></form>
33 - <br/>
34 - <b>{$languageSelectionText}:</b>
35 - {$languageSelection}
3629 </div>
3730 </div>
3831 EOD;
Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
@@ -43,8 +43,7 @@
4444 {$contentHtml}
4545 </div>
4646 {$footerHtml}
47 - <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js?version=20110920T172820Z"></script>
48 - <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/opensearchresults.js?version=20110921T172820Z"></script>
 47+ <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js?version=20110920T172820Z"></script>
4948 </body>
5049 </html>
5150 EOT;
Property changes on: trunk/extensions/MobileFrontend
___________________________________________________________________
Added: svn:mergeinfo
5251 Merged /trunk/extensions/MobileFrontend:r99727

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99728remove content headerpreilly20:30, 13 October 2011

Status & tagging log