r99687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99686‎ | r99687 | r99688 >
Date:16:10, 13 October 2011
Author:yaron
Status:deferred
Tags:
Comment:
Added sanity check to prevent crashes - in the long run, this shouldn't be necessary
Modified paths:
  • /trunk/extensions/PageSchemas/specials/PS_GeneratePages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageSchemas/specials/PS_GeneratePages.php
@@ -57,6 +57,7 @@
5858 $skin = $wgUser->getSkin();
5959 }
6060 foreach ( $pageList as $page ) {
 61+ if ( !( $page instanceof Title ) ) { continue; }
6162 $pageName = PageSchemas::titleString( $page );
6263 $text .= Html::input( 'page[]', $pageName, 'checkbox', array( 'checked' => true ) );
6364 $text .= "\n" . $skin->link( $page ) . "<br />\n";

Status & tagging log