r99583 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99582‎ | r99583 | r99584 >
Date:22:08, 11 October 2011
Author:erik
Status:ok
Tags:
Comment:
* Clarify purpose of different special pages
* De-list "sign-up" page (accessed through welcome page)
Modified paths:
  • /trunk/extensions/Contest/Contest.i18n.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestSignup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.i18n.php
@@ -43,7 +43,7 @@
4444
4545 // Preferences
4646 'prefs-contest' => 'Contests',
47 - 'contest-prefs-showtoplink' => 'Show a link to [[Special:MyContests|My Contests]] in the top menue.',
 47+ 'contest-prefs-showtoplink' => 'Show a link to [[Special:MyContests|My Contests]] in the top menu.',
4848
4949 // Contest statuses
5050 'contest-status-draft' => 'Draft (disabled)',
@@ -51,12 +51,12 @@
5252 'contest-status-finished' => 'Finished (disabled)',
5353
5454 // Special page names
55 - 'special-contest' => 'Contest',
56 - 'special-contests' => 'Contests',
57 - 'special-contestsignup' => 'Contest signup',
58 - 'special-contestwelcome' => 'Contest',
59 - 'special-editcontest' => 'Edit contest',
60 - 'special-mycontests' => 'Contests',
 55+ 'special-contest' => 'View a contest',
 56+ 'special-contests' => 'Manage contests',
 57+ 'special-contestsignup' => 'Sign up for a contest',
 58+ 'special-contestwelcome' => 'View a contest',
 59+ 'special-editcontest' => 'Edit a contest',
 60+ 'special-mycontests' => 'My contests',
6161
6262 // Navigation links
6363 'contest-nav-contests' => 'Contests list',
@@ -136,7 +136,7 @@
137137 'contest-signup-require-challenge' => 'You must select a challenge.',
138138 'contest-signup-invalid-cv' => 'You entered an invalid URL.',
139139
140 - 'contest-submission-submission' => 'Url to your submission',
 140+ 'contest-submission-submission' => 'Link to your submission',
141141 'contest-submission-invalid-url' => 'This URL does not match one of the allowed formats.',
142142
143143 // Special:Contest
@@ -196,7 +196,7 @@
197197
198198 'contest-submission-submit' => 'Submit',
199199 'contest-submission-unknown' => 'There is no contest with the provided name.',
200 - 'contest-submission-header' => 'On this page you can modify your submission until the deadline.',
 200+ 'contest-submission-header' => 'Thanks for participating in this contest! Once you have completed the challenge, you can add a link to you submission below.',
201201 'contest-submission-finished' => 'This contest has ended.',
202202 );
203203
Index: trunk/extensions/Contest/specials/SpecialContestSignup.php
@@ -43,8 +43,20 @@
4444 $this->showPage( $subPage );
4545 }
4646 }
47 -
 47+
4848 /**
 49+ * This page is unlisted because the only way to access it is though a contest
 50+ * landing page.
 51+ *
 52+ * @return false|boolean
 53+ */
 54+ public function isListed() {
 55+
 56+ return false;
 57+
 58+ }
 59+
 60+ /**
4961 * Handle form submission.
5062 *
5163 * @since 0.1
@@ -369,5 +381,5 @@
370382
371383 return true;
372384 }
373 -
 385+
374386 }

Status & tagging log