r99567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99566‎ | r99567 | r99568 >
Date:21:02, 11 October 2011
Author:brion
Status:deferred (Comments)
Tags:
Comment:
Suppress annoying PHP 5.3 warning due to use of PHP4-style references.

There are a *lot* more reference misuses in this extension that should be cleaned up, but I can't actually get the ext to fully work. On my trunk/1.19 test instance, with a maps API key manually set up, I see only a vertical space where the map should be. Some images and scripts get loaded, but not inserted... possibly something's incompatible with how we've changed some of the JS setup.

I'd also recommend that someone interested update this to Google Maps API v3 -- this doesn't require an API key for low-level usage, so should be easier to set up.
Modified paths:
  • /trunk/extensions/GoogleMaps/GoogleMaps.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleMaps/GoogleMaps.body.php
——@@ -356,7 +356,7 @@
357357 *
358358 * @return string - the HTML string to output for the <googlemap> tag
359359 **/
360 - function render16 ( $pContent, $pArgv, &$pParser ) {
 360+ function render16 ( $pContent, $pArgv, $pParser ) {
361361 global $wgGoogleMaps;
362362 // pass through to the main render function, creating a new parser
363363 // for parsing the local content

Comments

#Comment by Siebrand (talk | contribs)   21:41, 11 October 2011

Isn't this a really unmAintained extension with proper alternatives (like Maps)?

#Comment by Brion VIBBER (talk | contribs)   21:48, 11 October 2011

Quite possible, in which case we can at some point slap a big 'replaced with X' all over it. For people already using it, nice to fix their existing code though. :)

Status & tagging log