r99540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99539‎ | r99540 | r99541 >
Date:19:36, 11 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup a few more bits of documentation
Modified paths:
  • /trunk/extensions/Translate/tag/TranslatablePage.php (modified) (history)
  • /trunk/extensions/Translate/utils/MessageWebImporter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/TranslatablePage.php
@@ -433,8 +433,8 @@
434434 /**
435435 * Adds a tag which indicates that this page is
436436 * suitable for translation.
437 - * @param $revision integer
438 - * @param null $value
 437+ * @param $revision integer|Revision
 438+ * @param $value string
439439 */
440440 public function addMarkedTag( $revision, $value = null ) {
441441 $this->addTag( 'tp:mark', $revision, $value );
@@ -444,12 +444,18 @@
445445 /**
446446 * Adds a tag which indicates that this page source is
447447 * ready for marking for translation.
448 - * @param $revision integer
 448+ * @param $revision integer|Revision
449449 */
450450 public function addReadyTag( $revision ) {
451451 $this->addTag( 'tp:tag', $revision );
452452 }
453453
 454+ /**
 455+ * @param $tag
 456+ * @param $revision Revision
 457+ * @param $value string
 458+ * @throws MWException
 459+ */
454460 protected function addTag( $tag, $revision, $value = null ) {
455461 $dbw = wfGetDB( DB_MASTER );
456462
Index: trunk/extensions/Translate/utils/MessageWebImporter.php
@@ -376,10 +376,10 @@
377377 * @static
378378 * @throws MWException
379379 * @param Title $title
380 - * @param $message
381 - * @param $comment
382 - * @param null $user
383 - * @param int $editFlags
 380+ * @param $message
 381+ * @param $comment
 382+ * @param $user User
 383+ * @param $editFlags
384384 * @return array
385385 */
386386 public static function doImport( $title, $message, $comment, $user = null, $editFlags = 0 ) {

Status & tagging log