r99523 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r99522‎ \| r99523 \| r99524 >
Date:	18:30, 11 October 2011
Author:	reedy
Status:	ok
Tags:
Comment:	Fix comment blocks that start /* to /**
Modified paths:	/trunk/phase3/includes/DefaultSettings.php (modified) (history) /trunk/phase3/includes/Exception.php (modified) (history) /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history) /trunk/phase3/languages/messages/MessagesLv.php (modified) (history) /trunk/phase3/languages/messages/MessagesRu.php (modified) (history) /trunk/phase3/languages/messages/MessagesUk.php (modified) (history) /trunk/phase3/maintenance/fuzz-tester.php (modified) (history) /trunk/phase3/maintenance/populateParentId.php (modified) (history) /trunk/phase3/maintenance/populateRevisionLength.php (modified) (history) /trunk/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php (modified) (history) /trunk/phase3/tests/phpunit/includes/IPTest.php (modified) (history) /trunk/phase3/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history) /trunk/phase3/tests/phpunit/includes/media/JpegMetadataExtractorTest.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiInstallationConfig.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php (modified) (history) /trunk/phase3/tests/selenium/installer/MediaWikiUserInterfaceTestCase.php (modified) (history) /trunk/phase3/tests/selenium/suites/MediawikiCoreSmokeTestSuite.php (modified) (history) /trunk/phase3/tests/selenium/suites/SimpleSeleniumTestSuite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fuzz-tester.php
—	—	@@ -2395,8 +2395,8 @@
2396	2396
2397	2397	// ////////////////// HTML VALIDATION /////////////////////////
2398	2398
2399		-/*
2400		~~- ** Asks the validator whether this is valid HTML, or not.~~
	2399	+/**
	2400	+ * Asks the validator whether this is valid HTML, or not.
2401	2401	*/
2402	2402	function validateHTML( $text ) {
2403	2403
Index: trunk/phase3/maintenance/populateRevisionLength.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Populates the rev_len field for old revisions created before MW 1.10.
5	5	*
6	6	* This program is free software; you can redistribute it and/or modify
Index: trunk/phase3/maintenance/populateParentId.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Makes the required database updates for rev_parent_id
5	5	* to be of any use. It can be used for some simple tracking
6	6	* and to find new page edits by users.
Index: trunk/phase3/tests/selenium/suites/SimpleSeleniumTestSuite.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Sample test suite.
5	5	* Two ways to configure MW for these tests
6	6	* 1) If you are running multiple test suites, add the following in LocalSettings.php
Index: trunk/phase3/tests/selenium/suites/MediawikiCoreSmokeTestSuite.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Stubs for now. We're going to start populating this test.
5	5	*/
6	6	class MediawikiCoreSmokeTestSuite extends SeleniumTestSuite
Index: trunk/phase3/tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php
—	—	@@ -27,7 +27,7 @@
28	28	*
29	29	*/
30	30
31		-/*
	31	+/**
32	32	* Test Case ID : 10 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
33	33	* Test Case Name : Invalid/ blank values for fields in 'Name' page.
34	34	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once ( dirname( __FILE__ ) . '/MediaWikiInstallationCommonFunction.php' );
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 09 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : Invalid/ blank values for fields in 'Connect to database' page.
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php
—	—	@@ -31,7 +31,7 @@
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34	34
35		-/*
	35	+/**
36	36	* Test Case ID : 03 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
37	37	* Test Case Name : Install mediawiki on a already installed Mediawiki.]
38	38	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php
—	—	@@ -27,7 +27,7 @@
28	28	*
29	29	*/
30	30
31		-/*
	31	+/**
32	32	* Test Case ID : 29 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
33	33	* Test Case Name : Help field hint availability for the fields.
34	34	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 05 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : Install Mediawiki by updating the existing database.
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 30 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name :'Back' and 'Continue' button availability
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 01 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : Install Mediawiki using 'MySQL' database type successfully
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiInstallationConfig.php
—	—	@@ -28,7 +28,7 @@
29	29	*/
30	30
31	31
32		-/*
	32	+/**
33	33	* MediaWikiInstallerTestSuite.php can be run one time successfully
34	34	* with current value of the 'DB_NAME_PREFIX'.
35	35	* If you wish to run the suite more than one time, you need to change
—	—	@@ -39,7 +39,7 @@
40	40	define( 'PORT', "8080" );
41	41	define( 'HOST_NAME', "localhost" );
42	42
43		-/*
	43	+/**
44	44	* Use the followings to run the test suite in different browsers.
45	45	* Firefox : *firefox
46	46	* IE : *iexplore
Index: trunk/phase3/tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 06 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : Install Mediawiki using 'MySQL' database type successfully
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 14, 15, 16, 17 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : User selects 'Read me' link.
37	37	* User selects 'Release notes' link.
Index: trunk/phase3/tests/selenium/installer/MediaWikiUserInterfaceTestCase.php
—	—	@@ -29,7 +29,7 @@
30	30
31	31	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
32	32
33		-/*
	33	+/**
34	34	* Test Case ID : 18 - 27 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
35	35	* Test Case Name : UI of MediaWiki initial/ Language/ Welcome to MediaWiki!/ Connect to database/
36	36	* Database settings/ Name/ Options/ Install/ Complete/ Restart Inslation pages
Index: trunk/phase3/tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php
—	—	@@ -29,7 +29,7 @@
30	30
31	31	require_once ( dirname( __FILE__ ) . '/MediaWikiInstallationCommonFunction.php' );
32	32
33		-/*
	33	+/**
34	34	* Test Case ID : 02 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
35	35	* Test Case Name : Install MediaWiki with the same database and the different
36	36	* database prefixes(Share one database between multiple wikis).
Index: trunk/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php
—	—	@@ -31,7 +31,7 @@
32	32
33	33	require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
34	34
35		-/*
	35	+/**
36	36	* Test Case ID : 11, 12 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
37	37	* Test Case Name : Install mediawiki on a already installed Mediawiki.
38	38	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php
—	—	@@ -30,7 +30,7 @@
31	31
32	32	require_once ( dirname( __FILE__ ) . '/MediaWikiInstallationCommonFunction.php' );
33	33
34		-/*
	34	+/**
35	35	* Test Case ID : 04 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
36	36	* Test Case Name : Install MediaWiki with different Database accounts for web access.
37	37	* Version : MediaWiki 1.18alpha
Index: trunk/phase3/tests/phpunit/includes/media/JpegMetadataExtractorTest.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* @todo Could use a test of extended XMP segments. Hard to find programs that
5	5	* create example files, and creating my own in vim propbably wouldn't
6	6	* serve as a very good "test". (Adobe photoshop probably creates such files
Index: trunk/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Unit tests for wfExpandUrl()
5	5	*/
6	6
Index: trunk/phase3/tests/phpunit/includes/IPTest.php
—	—	@@ -1,5 +1,5 @@
2	2	<?php
3		-/*
	3	+/**
4	4	* Tests for IP validity functions. Ported from /t/inc/IP.t by avar.
5	5	*/
6	6
Index: trunk/phase3/tests/phpunit/includes/api/RandomImageGenerator.php
—	—	@@ -1,6 +1,6 @@
2	2	<?php
3	3
4		-/*
	4	+/**
5	5	* RandomImageGenerator -- does what it says on the tin.
6	6	* Requires Imagick, the ImageMagick library for PHP, or the command line equivalent (usually 'convert').
7	7	*
Index: trunk/phase3/includes/installer/DatabaseUpdater.php
—	—	@@ -8,7 +8,7 @@
9	9
10	10	require_once( dirname(__FILE__) . '/../../maintenance/Maintenance.php' );
11	11
12		-/*
	12	+/**
13	13	* Class for handling database updates. Roughly based off of updaters.inc, with
14	14	* a few improvements :)
15	15	*
Index: trunk/phase3/includes/DefaultSettings.php
—	—	@@ -2488,7 +2488,7 @@
2489	2489	*/
2490	2490	$wgResourceLoaderSources = array();
2491	2491
2492		-/*
	2492	+/**
2493	2493	* Default 'remoteBasePath' value for resource loader modules.
2494	2494	* If not set, then $wgScriptPath will be used as a fallback.
2495	2495	*/
—	—	@@ -3635,7 +3635,7 @@
3636	3636	'onView' => array()
3637	3637	);
3638	3638
3639		-/*
	3639	+/**
3640	3640	* Put user rights log entries for autopromotion in recent changes?
3641	3641	* @since 1.18
3642	3642	*/
Index: trunk/phase3/includes/Exception.php
—	—	@@ -131,7 +131,10 @@
132	132	}
133	133	}
134	134
135		~~- /* Return titles of this error page */~~
	135	+ /**
	136	+ * Return titles of this error page
	137	+ * @return String
	138	+ */
136	139	function getPageTitle() {
137	140	global $wgSitename;
138	141	return $this->msg( 'internalerror', "$wgSitename error" );
Index: trunk/phase3/languages/messages/MessagesRu.php
—	—	@@ -56,7 +56,7 @@
57	57	* @author გიორგიმელა
58	58	*/
59	59
60		-/*
	60	+/**
61	61	* Изменения сделанные в этом файле будут потеряны при обновлении MediaWiki.
62	62	*
63	63	* Если необходимо внести изменения в перевод отдельных строк интерфейса,
Index: trunk/phase3/languages/messages/MessagesLv.php
—	—	@@ -22,7 +22,7 @@
23	23	* @author לערי ריינהארט
24	24	*/
25	25
26		-/*
	26	+/**
27	27	* @copyright Copyright © 2006, Niklas Laxström
28	28	* @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
29	29	*/
Index: trunk/phase3/languages/messages/MessagesUk.php
—	—	@@ -35,7 +35,7 @@
36	36	* @author Тест
37	37	*/
38	38
39		-/*
	39	+/**
40	40	* УВАГА! НЕ РЕДАГУЙТЕ ЦЕЙ ФАЙЛ!
41	41	*
42	42	* Якщо необхідно змінити переклад окремих частин інтерфейсу,

Status & tagging log

12:36, 27 October 2011 Hashar (talk | contribs) changed the status of r99523 [removed: new added: ok]