r99515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99514‎ | r99515 | r99516 >
Date:18:17, 11 October 2011
Author:wikinaut
Status:ok
Tags:
Comment:
self-revert back to protected functions addIndex and dropIndex as suggested in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99510#c24137
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -432,7 +432,7 @@
433433 * @param $patch String Path to the patch file
434434 * @param $fullpath Boolean Whether to treat $patch path as a relative or not
435435 */
436 - public function addIndex( $table, $index, $patch, $fullpath = false ) {
 436+ protected function addIndex( $table, $index, $patch, $fullpath = false ) {
437437 if ( $this->db->indexExists( $table, $index ) ) {
438438 $this->output( "...$index key already set on $table table.\n" );
439439 } else {
@@ -468,7 +468,7 @@
469469 * @param $patch String: Path to the patch file
470470 * @param $fullpath Boolean: Whether to treat $patch path as a relative or not
471471 */
472 - public function dropIndex( $table, $index, $patch, $fullpath = false ) {
 472+ protected function dropIndex( $table, $index, $patch, $fullpath = false ) {
473473 if ( $this->db->indexExists( $table, $index ) ) {
474474 $this->output( "Dropping $index from table $table... " );
475475 $this->applyPatch( $patch, $fullpath );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99510chg protected to public function addIndex and dropIndex . This is i.a. needed...wikinaut17:52, 11 October 2011

Status & tagging log