r99414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99413‎ | r99414 | r99415 >
Date:18:19, 10 October 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r99413;
Modified paths:
  • /trunk/extensions/Contest/Contest.i18n.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialEditContest.php (modified) (history)
  • /trunk/extensions/Contest/sql/AddContestEmailFields.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.i18n.php
@@ -83,6 +83,8 @@
8484 'contest-edit-opportunities' => 'Opportunities page',
8585 'contest-edit-rulespage' => 'Rules page',
8686 'contest-edit-help' => 'Help page',
 87+ 'contest-edit-signup' => 'Signup email page',
 88+ 'contest-edit-reminder' => 'Reminder email page',
8789 'contest-edit-exists-already' => 'Note: you are editing an already existing contest, not creating a new one.',
8890 'contest-edit-submit' => 'Submit',
8991
Index: trunk/extensions/Contest/sql/AddContestEmailFields.sql
@@ -3,5 +3,5 @@
44 ADD COLUMN contest_reminder_email VARCHAR(255) NOT NULL;
55
66 UPDATE /*_*/contests SET
7 - contest_signup_email = '',
8 - contest_reminder_email = '';
\ No newline at end of file
 7+ contest_signup_email = 'MediaWiki:',
 8+ contest_reminder_email = 'MediaWiki:';
\ No newline at end of file
Index: trunk/extensions/Contest/specials/SpecialEditContest.php
@@ -195,6 +195,16 @@
196196 'label-message' => 'contest-edit-help',
197197 );
198198
 199+ $fields['signup_email'] = array (
 200+ 'type' => 'text',
 201+ 'label-message' => 'contest-edit-signup',
 202+ );
 203+
 204+ $fields['reminder_email'] = array (
 205+ 'type' => 'text',
 206+ 'label-message' => 'contest-edit-reminder',
 207+ );
 208+
199209 if ( $contest !== false ) {
200210 foreach ( $fields as $name => $data ) {
201211 $fields[$name]['default'] = $contest->getField( $name );
@@ -225,7 +235,9 @@
226236 * Process the form. At this point we know that the user passes all the criteria in
227237 * userCanExecute(), and if the data array contains 'Username', etc, then Username
228238 * resets are allowed.
229 - * @param $data array
 239+ *
 240+ * @param array $data
 241+ *
230242 * @return Bool|Array
231243 */
232244 public function onSubmit( array $data ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99413added fields for email pagesjeroendedauw18:11, 10 October 2011

Status & tagging log