r99331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99330‎ | r99331 | r99332 >
Date:00:05, 9 October 2011
Author:aaron
Status:deferred
Tags:
Comment:
* Make use of $wgPasswordSenderName
* Minor cleanups
Modified paths:
  • /trunk/extensions/ConfirmAccount/presentation/specialpages/actions/RequestAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/presentation/specialpages/actions/RequestAccount_body.php
@@ -104,7 +104,7 @@
105105 $form = Xml::openElement( 'form', array( 'method' => 'post', 'name' => 'accountrequest',
106106 'action' => $this->getTitle()->getLocalUrl(), 'enctype' => 'multipart/form-data' ) );
107107 $form .= '<fieldset><legend>' . wfMsgHtml( 'requestaccount-leg-user' ) . '</legend>';
108 - $form .= wfMsgExt( 'requestaccount-acc-text', array( 'parse' ) ) . "\n";
 108+ $form .= wfMsgExt( 'requestaccount-acc-text', 'parse' ) . "\n";
109109 $form .= '<table cellpadding=\'4\'>';
110110 if ( $wgUseRealNamesOnly ) {
111111 $form .= "<tr><td>" . wfMsgHtml( 'username' ) . "</td>";
@@ -132,7 +132,7 @@
133133 if ( count( $userAreas ) > 0 ) {
134134 $form .= '<fieldset>';
135135 $form .= '<legend>' . wfMsgHtml( 'requestaccount-leg-areas' ) . '</legend>';
136 - $form .= wfMsgExt( 'requestaccount-areas-text', array( 'parse' ) ) . "\n";
 136+ $form .= wfMsgExt( 'requestaccount-areas-text', 'parse' ) . "\n";
137137
138138 $form .= "<div style='height:150px; overflow:scroll; background-color:#f9f9f9;'>";
139139 $form .= "<table cellspacing='5' cellpadding='0' style='background-color:#f9f9f9;'><tr valign='top'>";
@@ -178,7 +178,7 @@
179179 if ( $wgAccountRequestExtraInfo ) {
180180 $form .= '<fieldset>';
181181 $form .= '<legend>' . wfMsgHtml( 'requestaccount-leg-other' ) . '</legend>';
182 - $form .= wfMsgExt( 'requestaccount-ext-text', array( 'parse' ) ) . "\n";
 182+ $form .= wfMsgExt( 'requestaccount-ext-text', 'parse' ) . "\n";
183183 if ( $wgAllowAccountRequestFiles ) {
184184 $form .= "<p>" . wfMsgHtml( 'requestaccount-attach' ) . " ";
185185 $form .= Xml::input( 'wpUploadFile', 35, '',
@@ -259,22 +259,22 @@
260260 $submission = new AccountRequestSubmission(
261261 $this->getUser(),
262262 array(
263 - 'userName' => $name,
264 - 'realName' => $this->mRealName,
265 - 'tosAccepted' => $this->mToS,
266 - 'email' => $this->mEmail,
267 - 'bio' => $this->mBio,
268 - 'notes' => $this->mNotes,
269 - 'urls' => $this->mUrls,
270 - 'type' => $this->mType,
271 - 'areas' => $this->mAreaSet,
272 - 'registration' => wfTimestampNow(),
273 - 'ip' => $this->getRequest()->getIP(),
274 - 'attachmentPrevName' => $this->mPrevAttachment,
275 - 'attachmentSrcName' => $this->mSrcName,
276 - 'attachmentDidNotForget' => $this->mForgotAttachment, // confusing name :)
277 - 'attachmentSize' => $this->mFileSize,
278 - 'attachmentTempPath' => $this->mTempPath
 263+ 'userName' => $name,
 264+ 'realName' => $this->mRealName,
 265+ 'tosAccepted' => $this->mToS,
 266+ 'email' => $this->mEmail,
 267+ 'bio' => $this->mBio,
 268+ 'notes' => $this->mNotes,
 269+ 'urls' => $this->mUrls,
 270+ 'type' => $this->mType,
 271+ 'areas' => $this->mAreaSet,
 272+ 'registration' => wfTimestampNow(),
 273+ 'ip' => $this->getRequest()->getIP(),
 274+ 'attachmentPrevName' => $this->mPrevAttachment,
 275+ 'attachmentSrcName' => $this->mSrcName,
 276+ 'attachmentDidNotForget' => $this->mForgotAttachment, // confusing name :)
 277+ 'attachmentSize' => $this->mFileSize,
 278+ 'attachmentTempPath' => $this->mTempPath
279279 )
280280 );
281281
@@ -317,7 +317,7 @@
318318 * @return void
319319 */
320320 protected function confirmEmailToken( $code ) {
321 - global $wgConfirmAccountContact, $wgPasswordSender;
 321+ global $wgConfirmAccountContact, $wgPasswordSender, $wgPasswordSenderName;
322322 $reqUser = $this->getUser();
323323 $out = $this->getOutput();
324324 # Confirm if this token is in the pending requests
@@ -328,7 +328,7 @@
329329 # Send mail to admin after e-mail has been confirmed
330330 if ( $wgConfirmAccountContact != '' ) {
331331 $target = new MailAddress( $wgConfirmAccountContact );
332 - $source = new MailAddress( $wgPasswordSender );
 332+ $source = new MailAddress( $wgPasswordSender, $wgPasswordSenderName );
333333 $title = SpecialPage::getTitleFor( 'ConfirmAccounts' );
334334 $subject = wfMsgForContent( 'requestaccount-email-subj-admin' );
335335 $body = wfMsgForContent(

Status & tagging log