r99288 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99287‎ | r99288 | r99289 >
Date:00:20, 8 October 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r99285
Modified paths:
  • /trunk/extensions/Contest/test/ContestValidationTests.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/test/ContestValidationTests.php
@@ -12,7 +12,7 @@
1313 class ContestValidationTests extends MediaWikiTestCase {
1414
1515 /**
16 - * Tests
 16+ * Tests @see SpecialContestSubmission::validateSubmissionField
1717 */
1818 public function testURLValidation() {
1919 $tests = array(
@@ -23,6 +23,7 @@
2424 'https://github.com/JeroenDeDauw/smwcon/tree/f9b26ec4ba1101b1f5d4ef76b7ae6ad3dabfb53' => false,
2525 'https://github.com/JeroenDeDauw/smwcon/tree/f9b26ec4ba1101b1f5d4ef76b7ae6ad3dabfb53ba' => false,
2626 'https://github.com/JeroenDeDauw/smwc*/tree/f9b26ec4ba1101b1f5d4ef76b7ae6ad3dabfb53b' => false,
 27+ 'in ur unit test, being quite silly' => false,
2728 );
2829
2930 foreach ( $tests as $test => $isValdid ) {
@@ -35,4 +36,15 @@
3637 }
3738 }
3839
 40+ /**
 41+ * Tests @see ContestDBObject::select and @see ContestDBObject::count
 42+ */
 43+ public function testObjectSelectCount() {
 44+ $classes = array( 'Contest', 'ContestChallenge' );
 45+
 46+ foreach ( $classes as $class ) {
 47+ $this->assertEquals( count( $class::s()->select() ), $class::s()->count() );
 48+ }
 49+ }
 50+
3951 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99285added testjeroendedauw00:04, 8 October 2011

Status & tagging log