r99156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99155‎ | r99156 | r99157 >
Date:22:25, 6 October 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r99154
Modified paths:
  • /branches/wmf/1.18wmf1/languages/Language.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/languages/Language.php
@@ -3051,8 +3051,12 @@
30523052 }
30533053
30543054 /**
3055 - * This translates the duration ("1 week", "4 days", etc)
3056 - * as well as the expiry time (which is an absolute timestamp).
 3055+ * @todo Maybe translate block durations. Note that this function is somewhat misnamed: it
 3056+ * deals with translating the *duration* ("1 week", "4 days", etc), not the expiry time
 3057+ * (which is an absolute timestamp). Please note: do NOT add this blindly, as it is used
 3058+ * on old expiry lengths recorded in log entries. You'd need to provide the start date to
 3059+ * match up with it.
 3060+ *
30573061 * @param $str String: the validated block duration in English
30583062 * @return Somehow translated block duration
30593063 * @see LanguageFi.php for example implementation
@@ -3076,8 +3080,8 @@
30773081 }
30783082 }
30793083 }
3080 - // If no duration is given, but a timestamp, display that
3081 - return ( strtotime( $str ) ? $this->timeanddate( strtotime( $str ) ) : $str );
 3084+ // If all else fails, return the original string.
 3085+ return $str;
30823086 }
30833087
30843088 /**
Property changes on: branches/wmf/1.18wmf1/languages/Language.php
___________________________________________________________________
Added: svn:mergeinfo
30853089 Merged /branches/REL1_17/phase3/languages/Language.php:r81445,81448
30863090 Merged /branches/nikola/phase3/languages/Language.php:r85224,85239,85308
30873091 Merged /branches/sqlite/languages/Language.php:r58211-58321
30883092 Merged /trunk/phase3/languages/Language.php:r92580,92713,92765,92884,92886-92887,92894,92898,92907,92932,93149,93151,93233-93234,93258,93266,93516-93518,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94346,94372,94422,94425,94444,94448,94456,94498,94601,94630,94728,94825,94862,94995-94997,95042,95155,95332,95410,95442,95468,95601,95812,99154
30893093 Merged /branches/new-installer/phase3/languages/Language.php:r43664-66004
30903094 Merged /branches/REL1_15/phase3/languages/Language.php:r51646

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99154* (bug 31352) Fix regression causing relative block times in log display to r...brion22:20, 6 October 2011

Status & tagging log