r99120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99119‎ | r99120 | r99121 >
Date:17:04, 6 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] Add implied dependency explicitly
* gadgetmanager.js uses mw.util.wikiScript, although the manager depends on the api module right now (which depends on mediawiki.util), adding it explicitly to the manager as well
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.php
——@@ -192,10 +192,11 @@
193193 'jquery.localize',
194194 'jquery.ui.autocomplete',
195195 'jquery.ui.dialog',
196 - 'mediawiki.Title',
197196 'jquery.createPropCloud',
198197 'jquery.json',
199198 'jquery.spinner',
 199+ 'mediawiki.Title',
 200+ 'mediawiki.util',
200201 ),
201202 'messages' => array(
202203 'gadgetmanager-editor-title-editing',

Status & tagging log