r9907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9906‎ | r9907 | r9908 >
Date:22:05, 4 July 2005
Author:vibber
Status:old
Tags:
Comment:
* Workaround for mysterious problem with bogus epoch If-Last-Modified reqs
Modified paths:
  • /branches/REL1_4/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_4/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_4/phase3/includes/OutputPage.php
@@ -103,7 +103,8 @@
104104 # Wed, 20 Aug 2003 06:51:19 GMT; length=5202
105105 # this breaks strtotime().
106106 $modsince = preg_replace( '/;.*$/', '', $_SERVER["HTTP_IF_MODIFIED_SINCE"] );
107 - $ismodsince = wfTimestamp( TS_MW, strtotime( $modsince ) );
 107+ $modsinceTime = strtotime( $modsince );
 108+ $ismodsince = wfTimestamp( TS_MW, $modsinceTime ? $modsinceTime : 1 );
108109 wfDebug( "-- client send If-Modified-Since: " . $modsince . "\n", false );
109110 wfDebug( "-- we might send Last-Modified : $lastmod\n", false );
110111 if( ($ismodsince >= $timestamp ) && $wgUser->validateCache( $ismodsince ) ) {
Index: branches/REL1_4/phase3/RELEASE-NOTES
@@ -665,7 +665,9 @@
666666 * Fixed a typo in the Romanian language file (NS_MESIA => NS_MEDIA)
667667 * (bug 2531) Changed the interwiki name for sh (Serbocroatian) to
668668 Srpskohrvatski/Српскохрватски (was Српскохрватски (Srbskohrvatski))
 669+* Workaround for mysterious problem with bogus epoch If-Last-Modified reqs
669670
 671+
670672 === Caveats ===
671673
672674 Some output, particularly involving user-supplied inline HTML, may not

Status & tagging log