r98972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98971‎ | r98972 | r98973 >
Date:01:45, 5 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Ported in r98971 from deployment
Modified paths:
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
@@ -118,11 +118,13 @@
119119 foreach ( $bar as $browseLinks ) {
120120 if ( $barnumber > 1 ) {
121121 $s .= "\n<hr class='sep' />";
122 - }
123 - foreach ( $browseLinks as $link ) {
124 - if ( $link['text'] != '-' ) {
125 - $s .= "<a href=\"{$link['href']}\">" .
126 - htmlspecialchars( $link['text'] ) . '</a>' . $sep;
 122+ }
 123+ if ( is_array( $browseLinks ) ) {
 124+ foreach ( $browseLinks as $link ) {
 125+ if ( $link['text'] != '-' ) {
 126+ $s .= "<a href=\"{$link['href']}\">" .
 127+ htmlspecialchars( $link['text'] ) . '</a>' . $sep;
 128+ }
127129 }
128130 }
129131 if ( $barnumber == 1 ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98971Check if $browseLinks is an array as CologneBlue doesaaron01:42, 5 October 2011

Status & tagging log