r98950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98949‎ | r98950 | r98951 >
Date:23:37, 4 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] getGadgetCategories: Allow array to be empty
* New fresh wikis don't have any categories. Fixes prototype js error
Modified paths:
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.api.js (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.api.js
@@ -247,8 +247,7 @@
248248 type: 'GET',
249249 dataType: 'json',
250250 success: function( data ) {
251 - if ( data && data.query && data.query.gadgetcategories
252 - && data.query.gadgetcategories[0] )
 251+ if ( data && data.query && data.query.gadgetcategories )
253252 {
254253 data = data.query.gadgetcategories;
255254 // Update cache

Follow-up revisions

RevisionCommit summaryAuthorDate
r98951[RL2] Pass error callback to getGadgetCategories...krinkle23:39, 4 October 2011

Status & tagging log