r98928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98927‎ | r98928 | r98929 >
Date:21:33, 4 October 2011
Author:aaron
Status:ok
Tags:
Comment:
MFT r98927
Modified paths:
  • /branches/wmf/1.18wmf1/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/specials/SpecialUndelete.php
@@ -399,6 +399,10 @@
400400
401401 # Does this page already exist? We'll have to update it...
402402 $article = new Article( $this->title );
 403+ # Load latest data for the current page (bug 31179)
 404+ $article->loadPageData( 'fromdbmaster' );
 405+ $oldcountable = $article->isCountable();
 406+
403407 $options = 'FOR UPDATE'; // lock page
404408 $page = $dbw->selectRow( 'page',
405409 array( 'page_id', 'page_latest' ),
@@ -532,7 +536,6 @@
533537 }
534538
535539 $created = (bool)$newid;
536 - $oldcountable = $article->isCountable();
537540
538541 // Attach the latest revision to the page...
539542 $wasnew = $article->updateIfNewerOn( $dbw, $revision, $previousRevId );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98927(bug 31179) Fixed problems with undeletion making bad page rows:...aaron21:31, 4 October 2011

Status & tagging log