r98833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98832‎ | r98833 | r98834 >
Date:23:45, 3 October 2011
Author:khorn
Status:ok
Tags:
Comment:
Found a bug that truncated some values during key-value array translation of a response from a namevalue-type gateway, if any of the values contain the character '='. This does actually come back from payflowpro: They send XML back as a value in the "FPS_PREXMLDATA" key if the transaction was flagged by their fraud protection. (Awesome)
r98498
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro.adapter.php (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro.adapter.php
——@@ -100,7 +100,7 @@
101101 */
102102 $result_arr = explode( "&", $nvString );
103103 foreach ( $result_arr as $result_pair ) {
104 - list( $key, $value ) = preg_split( "/=/", $result_pair );
 104+ list( $key, $value ) = preg_split( "/=/", $result_pair, 2 );
105105 $responseArray[$key] = $value;
106106 }
107107

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98498Rebuilding the payflowpro gateway and adapter, Part 2 of Several!...khorn01:45, 30 September 2011

Status & tagging log