r98824 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98823‎ | r98824 | r98825 >
Date:22:51, 3 October 2011
Author:reedy
Status:ok
Tags:
Comment:
More whitespace and comments
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /trunk/extensions/LilyPond/LilyPond.class.php (modified) (history)
  • /trunk/extensions/Translate/api/ApiQueryMessageCollection.php (modified) (history)
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -597,10 +597,17 @@
598598 }
599599 }
600600
 601+ /**
 602+ * @param $offset
 603+ * @return string
 604+ */
601605 function openList( $offset ) {
602606 return "\n<ol start='" . ( $offset + 1 ) . "' class='special'>\n";
603607 }
604608
 609+ /**
 610+ * @return string
 611+ */
605612 function closeList() {
606613 return "</ol>\n";
607614 }
Index: trunk/extensions/Translate/api/ApiQueryMessageCollection.php
@@ -55,7 +55,6 @@
5656
5757 $messages->slice( $params['offset'], $params['limit'] + 1 );
5858
59 -
6059 $messages->loadTranslations();
6160
6261 $result = $this->getResult();
@@ -89,6 +88,12 @@
9089
9190 }
9291
 92+ /**
 93+ * @param $result ApiResult
 94+ * @param $props array
 95+ * @param $message ThinMessage
 96+ * @return array
 97+ */
9398 public function extractMessageData( $result, $props, $message ) {
9499 $data['key'] = $message->key();
95100 if ( isset( $props['definition'] ) ) {
@@ -104,6 +109,9 @@
105110 return $data;
106111 }
107112
 113+ /**
 114+ * @return array
 115+ */
108116 public function getFilters() {
109117 $basic = MessageCollection::getAvailableFilters();
110118 $full = array();
Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -127,6 +127,9 @@
128128 }
129129 }
130130
 131+ /**
 132+ * @return Title
 133+ */
131134 public function getLogSubpageTitle() {
132135 if ( !isset( $this->logSubpageTitle ) ) {
133136 $this->logSubpageTitle = $this->getTitle( wfMsgForContent( 'checkuser-log-subpage' ) );
Index: trunk/extensions/LilyPond/LilyPond.class.php
@@ -296,4 +296,4 @@
297297 imagecopy( $dstImage, $srcImage, $borderWidth, $borderHeight, 0, 0, $width, $height );
298298 imagepng( $dstImage, $dest );
299299 }
300 - }
\ No newline at end of file
 300+}
\ No newline at end of file

Status & tagging log