r98784 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98783‎ | r98784 | r98785 >
Date:17:49, 3 October 2011
Author:brion
Status:ok
Tags:
Comment:
(bug 30560) Generate HTTPS links to Wikipedia or mediawiki.org from Bugzilla, so they match current protocol (bugzilla is https-only)

Seems to follow through for redirects (eg https://en.wikipedia.org/w/index.php?title=Special:Search&go=Go&search=fr:France ends up at https://fr.wikipedia.org/wiki/France )

URLs tested locally but not the ext itself. Someone will still need to deploy an update I assume.
Modified paths:
  • /trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm (modified) (history)

Diff [purge]

Index: trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm
@@ -47,7 +47,7 @@
4848 replace => \&_createCodeReviewLink
4949 };
5050 #~\br(\d+)\b
51 - # "<a href=\"http://www.mediawiki.org" .
 51+ # "<a href=\"https://www.mediawiki.org" .
5252 # "/wiki/Special:Code/MediaWiki/$1\" " .
5353 # "title=\"revision $1 in SVN\">r$1</a>"
5454
@@ -58,12 +58,12 @@
5959 sub _createWikipediaLink {
6060 my $match_str = $1;
6161 my $tmp = html_quote($match_str);
62 - my $wikipedia_link = "[[<a href='http://en.wikipedia.org/w/index.php?title=Special:Search&go=Go&search=$tmp'>$tmp</a>]]";
 62+ my $wikipedia_link = "[[<a href='https://en.wikipedia.org/w/index.php?title=Special:Search&go=Go&search=$tmp'>$tmp</a>]]";
6363 return $wikipedia_link;
6464 };
6565
6666 sub _createCodeReviewLink {
67 - my $rev_link = "<a href=\"http://www.mediawiki.org/wiki/Special:Code/MediaWiki/$1\" title=\"revision $1 in SVN\">r$1</a>";
 67+ my $rev_link = "<a href=\"https://www.mediawiki.org/wiki/Special:Code/MediaWiki/$1\" title=\"revision $1 in SVN\">r$1</a>";
6868 return $rev_link;
6969 };
7070

Status & tagging log