r98736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98735‎ | r98736 | r98737 >
Date:02:52, 3 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] Also load the module on [[Special:Gadgets/foo]]
Modified paths:
  • /branches/RL2/extensions/Gadgets/SpecialGadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/SpecialGadgets.php
@@ -413,10 +413,19 @@
414414 public function showSingleGadget( Gadget $gadget ) {
415415 $this->doSubpageMode();
416416 $out = $this->getOutput();
 417+ $user = $this->getUser();
417418
418419 $this->setHeaders();
419420 $out->setPagetitle( wfMsg( 'gadgets-gadget-title', $gadget->getTitleMessage() ) );
420421
 422+ // Only load the gadget manager module if needed
 423+ if ( $user->isAllowed( 'gadgets-definition-delete' )
 424+ || $user->isAllowed( 'gadgets-definition-edit' )
 425+ || $user->isAllowed( 'gadgets-definition-create' )
 426+ ) {
 427+ $out->addModules( 'ext.gadgets.gadgetmanager' );
 428+ }
 429+
421430 $out->addHTML( '<div class="mw-gadgets-list">' . $this->getGadgetHtml( $gadget ) . '</div>' );
422431 }
423432

Status & tagging log