r98709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98708‎ | r98709 | r98710 >
Date:20:07, 2 October 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r98707
Modified paths:
  • /branches/wmf/1.18wmf1/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/RELEASE-NOTES-1.18
@@ -211,6 +211,8 @@
212212 $wgDefaultUserOptions should no longer be used as it will contain those set via
213213 User:getDefaultOptions().
214214 * (bug 30722) Add a new collation that sorts categories in ascii sort order.
 215+* (bug 31293) If Special:Userlogin is loaded over HTTPS, display
 216+ MediaWiki:loginend-https instead of MediaWiki:loginend, if it exists
215217
216218 === Bug fixes in 1.18 ===
217219 * mw.util.getScript has been implemented (like wfScript in GlobalFunctions.php)
Property changes on: branches/wmf/1.18wmf1/RELEASE-NOTES-1.18
___________________________________________________________________
Modified: svn:mergeinfo
218220 Merged /trunk/phase3/RELEASE-NOTES-1.18:r98707
Index: branches/wmf/1.18wmf1/includes/templates/Userlogin.php
@@ -152,7 +152,7 @@
153153 <?php if( $this->haveData( 'token' ) ) { ?><input type="hidden" name="wpLoginToken" value="<?php $this->text( 'token' ); ?>" /><?php } ?>
154154 </form>
155155 </div>
156 -<div id="loginend"><?php $this->msgWiki( 'loginend' ); ?></div>
 156+<div id="loginend"><?php $this->html( 'loginend' ); ?></div>
157157 <?php
158158
159159 }
Index: branches/wmf/1.18wmf1/includes/specials/SpecialUserlogin.php
@@ -1034,6 +1034,14 @@
10351035 if( $this->mLanguage )
10361036 $template->set( 'uselang', $this->mLanguage );
10371037 }
 1038+
 1039+ // Use loginend-https for HTTPS requests if it exists, loginend otherwise
 1040+ $httpsMsg = wfMessage( 'loginend-https' );
 1041+ if ( WebRequest::detectProtocol() == 'https' && $httpsMsg->exists() ) {
 1042+ $template->set( 'loginend', $httpsMsg->parse() );
 1043+ } else {
 1044+ $template->set( 'loginend', wfMessage( 'loginend' )->parse() );
 1045+ }
10381046
10391047 // Give authentication and captcha plugins a chance to modify the form
10401048 $wgAuth->modifyUITemplate( $template, $this->mType );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98707(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:logi...catrope20:02, 2 October 2011

Status & tagging log