r98682 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98681‎ | r98682 | r98683 >
Date:16:14, 2 October 2011
Author:dantman
Status:deferred
Tags:
Comment:
Fix up some unnecessary code and an error in HistoryPager.
Modified paths:
  • /branches/pageoutput/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: branches/pageoutput/includes/HistoryPage.php
@@ -322,8 +322,8 @@
323323 protected $preventClickjacking = false;
324324
325325 function __construct( $historyPage, $year = '', $month = '', $tagFilter = '', $conds = array() ) {
326 - parent::__construct();
327326 $this->historyPage = $historyPage;
 327+ parent::__construct( $historyPage->getContext() );
328328 $this->tagFilter = $tagFilter;
329329 $this->getDateCond( $year, $month );
330330 $this->conds = $conds;
@@ -335,19 +335,6 @@
336336 return $this->historyPage->getArticle();
337337 }
338338
339 - function getTitle() {
340 - return $this->historyPage->getTitle();
341 - }
342 - function getUser() {
343 - return $this->historyPage->getUser();
344 - }
345 - function getLang() {
346 - return $this->historyPage->getLang();
347 - }
348 - function getOutput() {
349 - return $this->historyPage->getOutput();
350 - }
351 -
352339 function getSqlComment() {
353340 if ( $this->conds ) {
354341 return 'history page filtered'; // potentially slow, see CR r58153

Status & tagging log