r98633 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98632‎ | r98633 | r98634 >
Date:22:18, 1 October 2011
Author:reedy
Status:deferred
Tags:
Comment:
More explicit member variables

Documentation
Modified paths:
  • /trunk/extensions/Translate/Groups.php (modified) (history)
  • /trunk/extensions/Translate/specials/SpecialTranslationStats.php (modified) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
@@ -19,6 +19,12 @@
2020 * @ingroup SpecialPage PageTranslation
2121 */
2222 class SpecialPageTranslation extends SpecialPage {
 23+
 24+ /**
 25+ * @var User
 26+ */
 27+ protected $user;
 28+
2329 function __construct() {
2430 parent::__construct( 'PageTranslation' );
2531 }
Index: trunk/extensions/Translate/specials/SpecialTranslationStats.php
@@ -737,6 +737,8 @@
738738 /// \arrayof{String,\bool} Cache used to count active users only once per day.
739739 protected $usercache;
740740
 741+ protected $codes, $groups;
 742+
741743 public function __construct( FormOptions $opts ) {
742744 parent::__construct( $opts );
743745 // This query is slow... ensure a lower limit.
Index: trunk/extensions/Translate/Groups.php
@@ -133,10 +133,16 @@
134134 protected $conf;
135135 protected $namespace;
136136
 137+ protected $groups;
 138+
 139+ /**
 140+ * @var StringMatcher
 141+ */
 142+ protected $mangler;
 143+
137144 protected function __construct() { }
138145
139 - /**
140 - * @static
 146+ /*
141147 * @param $conf
142148 *
143149 * @return MessageGroup
@@ -498,6 +504,7 @@
499505 * @todo Currently unused?
500506 */
501507 class MediaWikiMessageGroup extends FileBasedMessageGroup {
 508+
502509 public function mapCode( $code ) {
503510 return ucfirst( str_replace( '-', '_', parent::mapCode( $code ) ) );
504511 }

Status & tagging log