r98630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98629‎ | r98630 | r98631 >
Date:21:28, 1 October 2011
Author:aaron
Status:deferred
Tags:
Comment:
FU r98628:
* Fixed field name case
* Fixed IS NULL check (was backwards)
Modified paths:
  • /trunk/extensions/ConfirmAccount/dataclasses/ConfirmAccount.class.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/presentation/specialpages/actions/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/dataclasses/ConfirmAccount.class.php
@@ -145,7 +145,7 @@
146146 public static function getOpenRequestCount( $type ) {
147147 $dbr = wfGetDB( DB_SLAVE );
148148 $open = (int)$dbr->selectField( 'account_requests', 'COUNT(*)',
149 - array( 'acr_type' => $type, 'acr_deleted' => 0, 'acr_held IS NOT NULL' ),
 149+ array( 'acr_type' => $type, 'acr_deleted' => 0, 'acr_held IS NULL' ),
150150 __METHOD__
151151 );
152152 $held = (int)$dbr->selectField( 'account_requests', 'COUNT(*)',
Index: trunk/extensions/ConfirmAccount/presentation/specialpages/actions/ConfirmAccount_body.php
@@ -14,7 +14,7 @@
1515 protected $reqBio;
1616 protected $submitType;
1717 protected $reqAreas;
18 - protected $reqAreaset;
 18+ protected $reqAreaSet;
1919 protected $reason;
2020
2121 function __construct() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98628ConfirmAccount special page cleanups:...aaron21:24, 1 October 2011

Status & tagging log