r98595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98594‎ | r98595 | r98596 >
Date:01:34, 1 October 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Cleanup
Modified paths:
  • /trunk/parsers/wikidom/lib/hype/models/es.DocumentModel.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/hype/models/es.DocumentModel.js
@@ -110,11 +110,13 @@
111111 }
112112 // Apply annotation to range
113113 if ( src.start < 0 ) {
114 - // TODO: This is invalid data! Throw error?
 114+ // TODO: The start can not be lower than 0! Throw error?
 115+ // Clamp start value
115116 src.start = 0;
116117 }
117118 if ( src.end > data.length ) {
118 - // TODO: This is invalid data! Throw error?
 119+ // TODO: The end can not be higher than the length! Throw error?
 120+ // Clamp end value
119121 src.end = data.length;
120122 }
121123 for ( var i = src.start; i < src.end; i++ ) {

Status & tagging log