r98575 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98574‎ | r98575 | r98576 >
Date:22:13, 30 September 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r98563, oops, forgot to use var for Javascript variables. Yikes
Modified paths:
  • /trunk/extensions/CategoryTree/modules/ext.categoryTree.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/modules/ext.categoryTree.js
@@ -31,7 +31,7 @@
3232 * Handles clicks on the expand buttons, and calls the appropriate function
3333 */
3434 this.handleNode = function() {
35 - $link = $( this );
 35+ var $link = $( this );
3636 if ( $link.data( 'ctState' ) == 'collapsed' ) {
3737 that.expandNode( $link );
3838 } else {
@@ -89,7 +89,7 @@
9090 + mw.msg( 'categorytree-loading' ) + "</i>"
9191 );
9292
93 - $parentTag = $link.parents( '.CategoryTreeTag' );
 93+ var $parentTag = $link.parents( '.CategoryTreeTag' );
9494
9595 if ( $parentTag.length == 0 ) {
9696 // Probably a CategoryPage
@@ -134,7 +134,7 @@
135135 that.showToggles();
136136 } )
137137 .error( function() {
138 - $retryLink = $( '<a />' )
 138+ var $retryLink = $( '<a />' )
139139 .text( mw.msg( 'categorytree-retry' ) )
140140 .attr( 'href', '#' )
141141 .click( function() { that.loadChildren( $link, $children ) } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98563Followup r98500, conversion of the Javascript to use jQuery fully. It also ma...johnduhart21:08, 30 September 2011

Status & tagging log