r98572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98571‎ | r98572 | r98573 >
Date:21:40, 30 September 2011
Author:aaron
Status:ok
Tags:
Comment:
MFT r98569
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php
@@ -309,13 +309,14 @@
310310 array( 'rev_user' => 0, $timeCondition, "(rev_id % $mod) = 0" ),
311311 __METHOD__,
312312 array(
313 - 'GROUP BY' => 'rev_id',
314 - 'USE INDEX' => array( 'p' => 'PRIMARY', 'n' => 'PRIMARY' )
 313+ 'GROUP BY' => array( 'rev_timestamp', 'rev_id' ), // user_timestamp INDEX used
 314+ 'USE INDEX' => array( 'revision' => 'user_timestamp' ), // sanity; mysql picks this
 315+ 'STRAIGHT_JOIN'
315316 ),
316317 array(
317318 'p' => array( 'INNER JOIN', array( // last review
318319 'p.fr_page_id = rev_page',
319 - 'p.fr_rev_id < rev_id',
 320+ 'p.fr_rev_id < rev_id', // not imported later
320321 'p.fr_timestamp < rev_timestamp' ) ),
321322 'n' => array( 'INNER JOIN', array( // next review
322323 'n.fr_page_id = rev_page',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98569Fixed totally broken query plan for anon edit stats....aaron21:31, 30 September 2011

Status & tagging log