r98515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98514‎ | r98515 | r98516 >
Date:14:17, 30 September 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
*(bug 26261) Bundle ParserFunctions extension with MediaWiki


Fuck. Yeah.
Modified paths:
  • /trunk/tools/make-release/make-release (modified) (history)

Diff [purge]

Index: trunk/tools/make-release/make-release
——@@ -205,6 +205,7 @@
206206
207207 # Export the target
208208 export(branch, package)
 209+ exportExtension(branch, 'ParserFunctions', package)
209210
210211 # Generate the .tar.gz file
211212 outFile = open(dir + '/' + package + '.tar.gz', 'w')

Follow-up revisions

RevisionCommit summaryAuthorDate
r98516Improvement on r98515, give an array of extensions to include (hard coded) an...reedy14:31, 30 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98494Add method for adding extensions to a release tarball...reedy00:23, 30 September 2011

Comments

#Comment by MZMcBride (talk | contribs)   14:21, 30 September 2011

:D

#Comment by Reedy (talk | contribs)   14:42, 30 September 2011

Just need to test (or ask Tim for confirmation) if it creates the patch properly for the extensions, or need to make it do diffs of the extensions directory also...

#Comment by Hashar (talk | contribs)   10:23, 13 December 2011

Have you made the tests? Since 1.18.0 was released with this script, I am assuming it should be fine today :)

#Comment by Reedy (talk | contribs)   10:43, 13 December 2011

Won't actually know till 1.18.1, we don't do major release patches, only between minor. And of coure

There's no reason to believe it won't, as it's not hardcoded as what to diff

#Comment by Hashar (talk | contribs)   17:08, 13 December 2011

So marking it OK. Will be fixed later if needed.

Status & tagging log