r98458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98457‎ | r98458 | r98459 >
Date:21:17, 29 September 2011
Author:aaron
Status:ok
Tags:lamecommitsummary 
Comment:
FU r98405: various document cleanup
Modified paths:
  • /trunk/phase3/includes/cache/FileCacheBase.php (modified) (history)
  • /trunk/phase3/includes/cache/HTMLFileCache.php (modified) (history)
  • /trunk/phase3/includes/cache/ObjectFileCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/ObjectFileCache.php
@@ -1,6 +1,16 @@
22 <?php
 3+/**
 4+ * Contain the ObjectFileCache class
 5+ * @file
 6+ * @ingroup Cache
 7+ */
38 class ObjectFileCache extends FileCacheBase {
4 -
 9+ /**
 10+ * Construct an ObjectFileCache from a key and a type
 11+ * @param $key string
 12+ * @param $type string
 13+ * @return ObjectFileCache
 14+ */
515 public static function newFromKey( $key, $type ) {
616 $cache = new self();
717
@@ -15,7 +25,7 @@
1626 return $cache;
1727 }
1828
19 - /*
 29+ /**
2030 * Get the type => extension mapping
2131 * @return array
2232 */
Index: trunk/phase3/includes/cache/FileCacheBase.php
@@ -1,6 +1,6 @@
22 <?php
33 /**
4 - * Contain the HTMLFileCache class
 4+ * Contain the FileCacheBase class
55 * @file
66 * @ingroup Cache
77 */
@@ -128,7 +128,7 @@
129129 return $text;
130130 }
131131
132 - /*
 132+ /**
133133 * Clear the cache for this page
134134 * @return void
135135 */
@@ -138,7 +138,7 @@
139139 wfRestoreWarnings();
140140 }
141141
142 - /*
 142+ /**
143143 * Create parent directors of $this->cachePath()
144144 * @TODO: why call wfMkdirParents() twice?
145145 * @return void
@@ -152,7 +152,7 @@
153153 wfMkdirParents( $mydir2, null, __METHOD__ );
154154 }
155155
156 - /*
 156+ /**
157157 * Return relative multi-level hash subdirectory with the trailing
158158 * slash or the empty string if $wgFileCacheDepth is off
159159 * @return string
Index: trunk/phase3/includes/cache/HTMLFileCache.php
@@ -5,7 +5,12 @@
66 * @ingroup Cache
77 */
88 class HTMLFileCache extends FileCacheBase {
9 -
 9+ /**
 10+ * Construct an ObjectFileCache from a Title and an action
 11+ * @param $title Title
 12+ * @param $action string
 13+ * @return HTMLFileCache
 14+ */
1015 public static function newFromTitle( Title $title, $action ) {
1116 $cache = new self();
1217
@@ -20,7 +25,7 @@
2126 return $cache;
2227 }
2328
24 - /*
 29+ /**
2530 * Cacheable actions
2631 * @return array
2732 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98405HTMLFileCache refactoring:...aaron08:18, 29 September 2011

Status & tagging log