r98373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98372‎ | r98373 | r98374 >
Date:22:00, 28 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
shared.css clean up:
* Use background-color instead of background when possible (to support cascading rules and don't reset the entire thing)
* no parens around url()
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -460,7 +460,7 @@
461461 /* feed links */
462462 a.feedlink {
463463 /* @embed */
464 - background: url("images/feed-icon.png") center left no-repeat;
 464+ background: url(images/feed-icon.png) center left no-repeat;
465465 padding-left: 16px;
466466 }
467467
@@ -477,12 +477,13 @@
478478 unicode-bidi: embed;
479479 }
480480
481 -/* wikitable class for skinning normal tables
482 - * keep on sync with commonPrint.css
 481+/**
 482+ * wikitable class for skinning normal tables
 483+ * keep in sync with commonPrint.css
483484 */
484485 table.wikitable {
485486 margin: 1em 1em 1em 0;
486 - background: #f9f9f9;
 487+ background-color: #f9f9f9;
487488 border: 1px #aaa solid;
488489 border-collapse: collapse;
489490 color: black;
@@ -493,7 +494,7 @@
494495 padding: 0.2em;
495496 }
496497 .wikitable th {
497 - background: #f2f2f2;
 498+ background-color: #f2f2f2;
498499 text-align: center;
499500 }
500501 .wikitable caption {

Status & tagging log