r98353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98352‎ | r98353 | r98354 >
Date:19:19, 28 September 2011
Author:catrope
Status:old
Tags:
Comment:
1.17wmf1: MFT r98340
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -685,12 +685,15 @@
686686
687687 // If we were already on the user talk page, then reload the page so that the
688688 // new WikiLove message is displayed.
 689+ // @todo: an expandUrl() would be very nice indeed!
689690 if (
690 - targetBaseUrl === currentBaseUrl
691 - // Compatibility with 1.17, 1.18
692 - || mw.config.get( 'wgServer' ) + targetBaseUrl === currentBaseUrl
693 - // Compatibility with protocol-relative URLs
 691+ mw.config.get( 'wgServer' ) + targetBaseUrl === currentBaseUrl
 692+ // Compatibility with 1.17 (mw.util.wikiGetlink prepends wgServer in 1.17)
 693+ || targetBaseUrl === currentBaseUrl
 694+ // Compatibility with protocol-relative URLs in 1.18+
694695 || window.location.protocol + mw.config.get( 'wgServer' ) + targetBaseUrl === currentBaseUrl
 696+ // Compatibility with protocol-relative URLs in 1.17
 697+ || window.location.protocol + targetBaseUrl === currentBaseUrl
695698 ) {
696699 window.location.reload();
697700 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98340wikiLove.core: fix breakage on 1.17 wikis with protocol-relative wgServer (bu......krinkle18:14, 28 September 2011

Status & tagging log