r98287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98286‎ | r98287 | r98288 >
Date:23:41, 27 September 2011
Author:sean_colombo
Status:deferred
Tags:
Comment:
ApiExplorer: fix path to JS API client & tweak colors/spacing after extension was reviewed by Design Team.
Modified paths:
  • /trunk/extensions/ApiExplorer/SpecialApiExplorer.php (modified) (history)
  • /trunk/extensions/ApiExplorer/apiExplorer.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ApiExplorer/SpecialApiExplorer.php
@@ -54,7 +54,7 @@
5555 // TODO: Make this work for ResourceLoader (Wikia isn't using RL yet at the time of this writing).
5656 // Wikia has the cachebuster in the wgExtensionPath (we rewrite that in varnish because many proxies won't cache things that have "?" in the URL), but other MediaWikis need the style-version in the querystring.
5757 $cbSuffix = ( isset($wgCityId) ? "?{$wgStyleVersion}" : "" );
58 - $wgOut->addScript( "<script type=\"text/javascript\" src=\"{$wgExtensionsPath}/JavascriptAPI/Mediawiki.js{$cbSuffix}\"></script>" );
 58+ $wgOut->addScript( "<script type=\"text/javascript\" src=\"{$wgExtensionsPath}/wikia/JavascriptAPI/Mediawiki.js{$cbSuffix}\"></script>" );
5959 $wgOut->addScript( "<script type=\"text/javascript\" src=\"{$wgExtensionsPath}/ApiExplorer/apiExplorer.js{$cbSuffix}\"></script>" );
6060 $wgOut->addScript( "<link rel=\"stylesheet\" type=\"text/css\" href=\"{$wgExtensionsPath}/ApiExplorer/apiExplorer.css{$cbSuffix}\" />" );
6161
Index: trunk/extensions/ApiExplorer/apiExplorer.css
@@ -2,6 +2,9 @@
33 #apEx{
44 display:none;
55 }
 6+#apEx_intro{
 7+ margin-bottom:15px;
 8+}
69 #apEx_loading{
710 display:none;
811 }
@@ -26,14 +29,14 @@
2730 }
2831
2932 .paramContent{
30 - border-left: 2px solid #008;
31 - border-right: 2px solid #008;
 33+ border-left: 2px solid #023c71;
 34+ border-right: 2px solid #023c71;
3235 }
3336 div.paramContent{ /* Top level*/
34 - background-color: #bdf;
 37+ background-color: #d3eaff;
3538 }
3639 dd.paramContent{ /* per-module */
37 - background-color:#bfd;
 40+ background-color:#c4e19f;
3841 }
3942
4043 .collapsible h2, .collapsible h3{
@@ -41,7 +44,7 @@
4245 margin:0px;
4346 text-decoration:none;
4447 cursor:pointer;
45 - border:2px solid #008;
 48+ border:2px solid #023c71;
4649 -webkit-border-radius: 10px;
4750 -moz-border-radius: 10px;
4851 border-radius: 10px;
@@ -53,25 +56,19 @@
5457 }
5558 .collapsible.collapsed h2, .collapsible.collapsed h3, .paramContent{
5659 /* Collapsed state for h2, h3 or expanded for content... show bottom border & rounded corners */
57 - border-bottom:2px solid #008;
 60+ border-bottom:2px solid #023c71;
5861 border-bottom-left-radius:10px;
5962 border-bottom-right-radius:10px;
6063 }
6164
6265 #apEx div.collapsible h2{
63 - /* Pretty gradient background */
64 - background-image: linear-gradient(bottom, rgb(10,74,143) 43%, rgb(52,112,217) 72%);
65 - background-image: -o-linear-gradient(bottom, rgb(10,74,143) 43%, rgb(52,112,217) 72%);
66 - background-image: -moz-linear-gradient(bottom, rgb(10,74,143) 43%, rgb(52,112,217) 72%);
67 - background-image: -webkit-linear-gradient(bottom, rgb(10,74,143) 43%, rgb(52,112,217) 72%);
68 - background-image: -ms-linear-gradient(bottom, rgb(10,74,143) 43%, rgb(52,112,217) 72%);
69 - background-image: -webkit-gradient(
70 - linear,
71 - left bottom,
72 - left top,
73 - color-stop(0.43, rgb(10,74,143)),
74 - color-stop(0.72, rgb(52,112,217))
75 - );
 66+ /* Pretty gradient background for top-level button (blue) */
 67+ background-image: -ms-linear-gradient(top, #2C85D6 0%, #00396D 100%);
 68+ background-image: -moz-linear-gradient(top, #2C85D6 0%, #00396D 100%);
 69+ background-image: -o-linear-gradient(top, #2C85D6 0%, #00396D 100%);
 70+ background-image: -webkit-gradient(linear, left top, left bottom, color-stop(0, #2C85D6), color-stop(1, #00396D));
 71+ background-image: -webkit-linear-gradient(top, #2C85D6 0%, #00396D 100%);
 72+ background-image: linear-gradient(top, #2C85D6 0%, #00396D 100%);
7673
7774 color:white;
7875 }
@@ -83,23 +80,17 @@
8481
8582 /** Second-level of style... the dts **/
8683 #apEx dt h3, #apEx dt dd{
87 - border-color: #080;
 84+ border-color: #567c26;
8885 box-shadow: 4px 4px 4px #888888;
8986 }
9087 #apEx dt h3{
9188 padding:5px;
9289
93 - background-image: linear-gradient(bottom, rgb(40,230,30) 48%, rgb(133,248,156) 74%);
94 - background-image: -o-linear-gradient(bottom, rgb(40,230,30) 48%, rgb(133,248,156) 74%);
95 - background-image: -moz-linear-gradient(bottom, rgb(40,230,30) 48%, rgb(133,248,156) 74%);
96 - background-image: -webkit-linear-gradient(bottom, rgb(40,230,30) 48%, rgb(133,248,156) 74%);
97 - background-image: -ms-linear-gradient(bottom, rgb(40,230,30) 48%, rgb(133,248,156) 74%);
98 -
99 - background-image: -webkit-gradient(
100 - linear,
101 - left bottom,
102 - left top,
103 - color-stop(0.48, rgb(40,230,30)),
104 - color-stop(0.74, rgb(133,248,156))
105 - );
 90+ /* Pretty gradient for module-level buttons (green) */
 91+ background-image: -ms-linear-gradient(top, #D7F3B3 0%, #6DA822 100%);
 92+ background-image: -moz-linear-gradient(top, #D7F3B3 0%, #6DA822 100%);
 93+ background-image: -o-linear-gradient(top, #D7F3B3 0%, #6DA822 100%);
 94+ background-image: -webkit-gradient(linear, left top, left bottom, color-stop(0, #D7F3B3), color-stop(1, #6DA822));
 95+ background-image: -webkit-linear-gradient(top, #D7F3B3 0%, #6DA822 100%);
 96+ background-image: linear-gradient(top, #D7F3B3 0%, #6DA822 100%);
10697 }

Status & tagging log