r98274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98273‎ | r98274 | r98275 >
Date:22:16, 27 September 2011
Author:aaron
Status:deferred
Tags:
Comment:
Moved some config definitions and added comments
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount.php
@@ -62,8 +62,12 @@
6363
6464 # Show ToS checkbox
6565 $wgAccountRequestToS = true;
66 -# Show confirmation info fields
 66+# Show confirmation info fields (notes,url,files if enabled)
6767 $wgAccountRequestExtraInfo = true;
 68+# If $wgAccountRequestExtraInfo, also enables file attachments
 69+$wgAllowAccountRequestFiles = true;
 70+# If files can be attached, what types can be used? (MIME data is checked)
 71+$wgAccountRequestExts = array( 'txt', 'pdf', 'doc', 'latex', 'rtf', 'text', 'wp', 'wpd', 'sxw' );
6872
6973 # Prospective account access levels.
7074 # An associative array of integer => (special page param,user group,autotext) pairs.
@@ -95,9 +99,6 @@
96100 # inject catpchas for requests too?
97101 $wgConfirmAccountCaptchas = true;
98102
99 -$wgAllowAccountRequestFiles = true;
100 -$wgAccountRequestExts = array( 'txt', 'pdf', 'doc', 'latex', 'rtf', 'text', 'wp', 'wpd', 'sxw' );
101 -
102103 # Storage repos. Has B/C for when this used FileStore.
103104 $wgConfirmAccountFSRepos = array(
104105 'accountreqs' => array( # Location of attached files for pending requests
@@ -131,9 +132,9 @@
132133 # If credentials are stored, this right lets users look them up
133134 $wgGroupPermissions['bureaucrat']['lookupcredentials'] = true;
134135
135 -$wgAvailableRights[] = 'confirmaccount';
136 -$wgAvailableRights[] = 'requestips';
137 -$wgAvailableRights[] = 'lookupcredentials';
 136+$wgAvailableRights[] = 'confirmaccount'; // user can confirm account requests
 137+$wgAvailableRights[] = 'requestips'; // user can see IPs in request queue
 138+$wgAvailableRights[] = 'lookupcredentials'; // user can lookup info on confirmed users
138139
139140 # Show notice for open requests to admins?
140141 # This is cached, but still can be expensive on sites with thousands of requests.
@@ -185,6 +186,7 @@
186187 $wgHooks['AbortNewAccount'][] = 'ConfirmAccountUIHooks::checkIfAccountNameIsPending';
187188 # Status header like "new messages" bar
188189 $wgHooks['SiteNoticeAfter'][] = 'ConfirmAccountUIHooks::confirmAccountsNotice';
 190+
189191 # Register admin pages for AdminLinks extension.
190192 $wgHooks['AdminLinks'][] = 'ConfirmAccountUIHooks::confirmAccountAdminLinks';
191193

Status & tagging log