r98205 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98204‎ | r98205 | r98206 >
Date:01:40, 27 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Added type hinting to reveal fatals sooner
Modified paths:
  • /branches/wmf/1.18wmf1/includes/Linker.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/Linker.php
@@ -828,7 +828,7 @@
829829 * @param $time string: MW timestamp of file creation time
830830 * @return String: HTML
831831 */
832 - public static function makeMediaLinkObj( $title, $text = '', $time = false ) {
 832+ public static function makeMediaLinkObj( Title $title, $text = '', $time = false ) {
833833 $img = wfFindFile( $title, array( 'time' => $time ) );
834834 return self::makeMediaLinkFile( $title, $img, $text );
835835 }

Status & tagging log