r98189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98188‎ | r98189 | r98190 >
Date:22:46, 26 September 2011
Author:aaron
Status:ok
Tags:
Comment:
FU r98109: !EMPTY -> !NONEXISTENT (more consistent with elsewhere)
Modified paths:
  • /trunk/phase3/includes/interwiki/Interwiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/interwiki/Interwiki.php
@@ -151,7 +151,7 @@
152152 if ( !$iwData ) {
153153 $key = wfMemcKey( 'interwiki', $prefix );
154154 $iwData = $wgMemc->get( $key );
155 - if ( $iwData === '!EMPTY' ) {
 155+ if ( $iwData === '!NONEXISTENT' ) {
156156 return false; // negative cache hit
157157 }
158158 }
@@ -179,7 +179,7 @@
180180 $wgMemc->add( $key, $mc, $wgInterwikiExpiry );
181181 return $iw;
182182 } else {
183 - $wgMemc->add( $key, '!EMPTY', $wgInterwikiExpiry ); // negative cache hit
 183+ $wgMemc->add( $key, '!NONEXISTENT', $wgInterwikiExpiry ); // negative cache hit
184184 }
185185
186186 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98109Cache negative results for interwiki prefix checks. Also helps filecache fail...aaron03:37, 26 September 2011

Status & tagging log