r98156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98155‎ | r98156 | r98157 >
Date:18:49, 26 September 2011
Author:sean_colombo
Status:ok
Tags:
Comment:
Followup to r97342 to remove the now-unneeded checks for empty username & to add some spaces ;)
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -330,7 +330,6 @@
331331 * @return String: Formatted HTML list item
332332 */
333333 public function logLine( $row ) {
334 - $row->user_name = $this->fixUserName($row->user_name, $row->log_user);
335334 $entry = DatabaseLogEntry::newFromRow( $row );
336335 $formatter = LogFormatter::newFromEntry( $entry );
337336 $formatter->setShowUserToolLinks( !( $this->flags & self::NO_EXTRA_USER_LINKS ) );
@@ -718,7 +717,7 @@
719718 }
720719
721720 /* hook can return false, if we don't want the message to be emitted (Wikia BugId:7093) */
722 - if (!wfRunHooks('LogEventsListShowLogExtract', array(&$s, $types, $page, $user, $param))) {
 721+ if ( !wfRunHooks( 'LogEventsListShowLogExtract', array( &$s, $types, $page, $user, $param ) ) ) {
723722 return $pager->getNumRows();
724723 }
725724
@@ -756,25 +755,8 @@
757756 }
758757 return false;
759758 }
 759+ }
760760
761 - /**
762 - * if user_name is empty - use User class to get his name
763 - * @param $user_name string
764 - * @param $user_id integer
765 - * @return string
766 - */
767 - public function fixUserName($user_name, $user_id) {
768 - if ( empty($user_name) ) {
769 - $oUser = User::newFromID($user_id);
770 - if ( $oUser instanceof User ) {
771 - $user_name = $oUser->getName();
772 - }
773 - }
774 -
775 - return $user_name;
776 - }
777 -}
778 -
779761 /**
780762 * @ingroup Pager
781763 */
@@ -1035,10 +1017,6 @@
10361018 if( $this->getNumRows() > 0 ) {
10371019 $lb = new LinkBatch;
10381020 foreach ( $this->mResult as $row ) {
1039 - $row->user_name = $this->mLogEventsList->fixUserName($row->user_name, $row->log_user);
1040 - if ( empty($row->user_name) ) {
1041 - continue;
1042 - }
10431021 $lb->add( $row->log_namespace, $row->log_title );
10441022 $lb->addObj( Title::makeTitleSafe( NS_USER, $row->user_name ) );
10451023 $lb->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->user_name ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97342Merged in changes from LogEventsList which prevent missing usernames in log-l...sean_colombo22:30, 16 September 2011

Status & tagging log