r98145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98144‎ | r98145 | r98146 >
Date:17:24, 26 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Fix stupid bug in r98137: wrapper around $.fn.data didn't preserve this when calling the real data() function
Modified paths:
  • /branches/wmf/1.17wmf1/resources/jquery/jquery.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/resources/jquery/jquery.js
@@ -6242,9 +6242,9 @@
62436243 var oldData = jQuery.fn.data;
62446244 jQuery.fn.data = function( key, value ) {
62456245 if ( value === undefined ) {
6246 - return this.attr( 'data-' + key ) || oldData( key, value );
 6246+ return this.attr( 'data-' + key ) || oldData.apply( this, [key, value] );
62476247 } else {
6248 - return oldData( key, value );
 6248+ return oldData.apply( this, [key, value] );
62496249 }
62506250 };
62516251

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r981371.17wmf1: Add mediawiki.page.startup to 1.17wmf1 so I can use the client-nojs...catrope15:18, 26 September 2011

Status & tagging log