r98124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98123‎ | r98124 | r98125 >
Date:11:51, 26 September 2011
Author:catrope
Status:ok
Tags:
Comment:
MoodBar: Fix positioning issues with the spinner by undoing the repositioning of .mw-ajax-loader from shared.css on our spinner, and fix resizing flickers by styling the nomore/noresult/error messages to have font-size: 1.4em; just like the More, Newer and Older links
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css
@@ -101,7 +101,8 @@
102102 background-color: #e8f2f8;
103103 }
104104
105 -#fbd-list-more a, #fbd-list-newer a, #fbd-list-older a,
 105+#fbd-list-more a, #fbd-list-more span,
 106+#fbd-list-newer a, #fbd-list-older a,
106107 #fbd-list-newer .fbd-page-disabled, #fbd-list-older .fbd-page-disabled {
107108 font-size: 1.4em;
108109 background-repeat: no-repeat;
@@ -127,6 +128,11 @@
128129 padding-left: 20px;
129130 }
130131
 132+#fbd-list-more.mw-ajax-loader {
 133+ /* Undo the repositioning done in shared.css. Padding is set to 0.5em above. */
 134+ position: static;
 135+}
 136+
131137 /* The images here are named -ltr instead of -left and -rtl instead of -right
132138 * because ResourceLoader flips -ltr and -rtl in URLs, but not -left and -right
133139 */

Status & tagging log