r98098 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98097‎ | r98098 | r98099 >
Date:00:00, 26 September 2011
Author:aaron
Status:deferred
Tags:
Comment:
Cleaned up timestamp columns for sanity
Modified paths:
  • /trunk/extensions/ConfirmAccount/schema/mysql/ConfirmAccount.sql (modified) (history)
  • /trunk/extensions/ConfirmAccount/schema/mysql/patch-account_credentials.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/schema/mysql/patch-account_credentials.sql
@@ -20,7 +20,7 @@
2121 -- Initially NULL; when a user's e-mail address has been
2222 -- validated by returning with a mailed token, this is
2323 -- set to the current timestamp.
24 - acd_email_authenticated binary(14) default NULL,
 24+ acd_email_authenticated varbinary(14) default NULL,
2525 -- A little about this user
2626 acd_bio mediumblob NOT NULL,
2727 -- Private info for reviewers to look at when considering request
@@ -36,10 +36,10 @@
3737 acd_areas mediumblob NOT NULL,
3838
3939 -- Timestamp of account registration.
40 - acd_registration char(14) NOT NULL,
 40+ acd_registration varbinary(14) NOT NULL,
4141
4242 -- Timestamp of acceptance
43 - acd_accepted binary(14),
 43+ acd_accepted varbinary(14),
4444 -- The user who accepted it
4545 acd_user int unsigned NOT NULL default 0,
4646 -- Reason given in email
Index: trunk/extensions/ConfirmAccount/schema/mysql/ConfirmAccount.sql
@@ -21,12 +21,12 @@
2222 -- Initially NULL; when a user's e-mail address has been
2323 -- validated by returning with a mailed token, this is
2424 -- set to the current timestamp.
25 - acr_email_authenticated binary(14) default NULL,
 25+ acr_email_authenticated varbinary(14) default NULL,
2626 -- Randomly generated token created when the e-mail address
2727 -- is set and a confirmation test mail sent.
2828 acr_email_token binary(32),
2929 -- Expiration date for the user_email_token
30 - acr_email_token_expires binary(14),
 30+ acr_email_token_expires varbinary(14),
3131 -- A little about this user
3232 acr_bio mediumblob NOT NULL,
3333 -- Private info for reviewers to look at when considering request
@@ -44,14 +44,14 @@
4545 acr_areas mediumblob NOT NULL,
4646
4747 -- Timestamp of account registration.
48 - acr_registration char(14) NOT NULL,
 48+ acr_registration varbinary(14) NOT NULL,
4949
5050 -- Flag for rejected accounts
5151 acr_deleted bool NOT NULL,
5252 -- Time of rejection (if rejected)
53 - acr_rejected binary(14),
 53+ acr_rejected varbinary(14),
5454 -- Time request was put on hold (if held)
55 - acr_held binary(14),
 55+ acr_held varbinary(14),
5656 -- The user who rejected/held it
5757 acr_user int unsigned NOT NULL default 0,
5858 -- Reason
@@ -78,7 +78,7 @@
7979 -- Initially NULL; when a user's e-mail address has been
8080 -- validated by returning with a mailed token, this is
8181 -- set to the current timestamp.
82 - acd_email_authenticated binary(14) default NULL,
 82+ acd_email_authenticated varbinary(14) default NULL,
8383 -- A little about this user
8484 acd_bio mediumblob NOT NULL,
8585 -- Private info for reviewers to look at when considering request
@@ -94,10 +94,10 @@
9595 acd_areas mediumblob NOT NULL,
9696
9797 -- Timestamp of account registration.
98 - acd_registration char(14) NOT NULL,
 98+ acd_registration varbinary(14) NOT NULL,
9999
100100 -- Timestamp of acceptance
101 - acd_accepted binary(14),
 101+ acd_accepted varbinary(14),
102102 -- The user who accepted it
103103 acd_user int unsigned NOT NULL default 0,
104104 -- Reason given in email

Status & tagging log