r98077 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98076‎ | r98077 | r98078 >
Date:18:57, 25 September 2011
Author:raymond
Status:ok
Tags:
Comment:
Add comments per CR in r97902.
Modified paths:
  • /trunk/extensions/Renameuser/Renameuser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/Renameuser_body.php
@@ -308,8 +308,12 @@
309309 !$suppressRedirect
310310 );
311311 if ( $success === true ) {
 312+ # oldPage is not known in case of redirect suppression
312313 $oldLink = Linker::link( $oldPage, null, array(), array( 'redirect' => 'no' ) );
 314+
 315+ # newPage is always known because the move was successful
313316 $newLink = Linker::linkKnown( $newPage );
 317+
314318 $output .= Html::rawElement(
315319 'li',
316320 array( 'class' => 'mw-renameuser-pm' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97902linkKnown() -> link() because the existence of $oldPage depends on $suppressR...raymond10:11, 23 September 2011

Status & tagging log