r98068 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98067‎ | r98068 | r98069 >
Date:16:39, 25 September 2011
Author:ashley
Status:ok
Tags:
Comment:
SocialProfile: change hardcoded table options to /*$wgDBTableOptions*/ in all SQL files
Modified paths:
  • /trunk/extensions/SocialProfile/SystemGifts/systemgifts.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserBoard/user_board.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserGifts/usergifts.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/user_profile.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserRelationship/user_relationship.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/user_stats.sql (modified) (history)
  • /trunk/extensions/SocialProfile/UserSystemMessages/user_system_messages.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/SystemGifts/systemgifts.sql
@@ -5,7 +5,7 @@
66 `sg_user_name` varchar(255) NOT NULL default '',
77 `sg_status` int(2) default '1',
88 `sg_date` datetime default NULL
9 -) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 9+) /*$wgDBTableOptions*/;
1010 CREATE INDEX /*i*/sg_user_id ON /*_*/user_system_gift (`sg_user_id`);
1111 CREATE INDEX /*i*/sg_gift_id ON /*_*/user_system_gift (`sg_gift_id`);
1212
@@ -17,6 +17,6 @@
1818 `gift_category` int(11) default '0',
1919 `gift_threshold` int(15) default '0',
2020 `gift_createdate` datetime default NULL
21 -) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 21+) /*$wgDBTableOptions*/;
2222 CREATE INDEX /*i*/giftcategoryidx ON /*_*/system_gift (`gift_category`);
2323 CREATE INDEX /*i*/giftthresholdidx ON /*_*/system_gift (`gift_threshold`);
Index: trunk/extensions/SocialProfile/UserBoard/user_board.sql
@@ -11,7 +11,7 @@
1212 `ub_message` text NOT NULL,
1313 `ub_type` int(5) default '0',
1414 `ub_date` datetime default NULL
15 -) DEFAULT CHARSET=utf8;
 15+) /*$wgDBTableOptions*/;
1616 CREATE INDEX /*i*/ub_user_id ON /*_*/user_board (ub_user_id);
1717 CREATE INDEX /*i*/ub_user_id_from ON /*_*/user_board (ub_user_id_from);
1818 CREATE INDEX /*i*/ub_type ON /*_*/user_board (ub_type);
Index: trunk/extensions/SocialProfile/UserStats/user_stats.sql
@@ -48,4 +48,4 @@
4949 `stats_quiz_questions_correct_percent` float default '0',
5050 `stats_links_submitted` int(11) NOT NULL default '0',
5151 `stats_links_approved` int(11) NOT NULL default '0'
52 -) DEFAULT CHARSET=utf8;
 52+) /*$wgDBTableOptions*/;
Index: trunk/extensions/SocialProfile/UserProfile/user_profile.sql
@@ -35,4 +35,4 @@
3636 `up_custom_5` text,
3737 `up_last_seen` datetime default NULL,
3838 `up_type` int(5) NOT NULL default '1'
39 -) DEFAULT CHARSET=utf8;
 39+) /*$wgDBTableOptions*/;
Index: trunk/extensions/SocialProfile/UserRelationship/user_relationship.sql
@@ -10,7 +10,7 @@
1111 `r_user_name_relation` varchar(255) NOT NULL default '',
1212 `r_type` int(2) default NULL,
1313 `r_date` datetime default NULL
14 -) DEFAULT CHARSET=utf8;
 14+) /*$wgDBTableOptions*/;
1515 CREATE INDEX /*i*/r_user_id ON /*_*/user_relationship (`r_user_id`);
1616 CREATE INDEX /*i*/r_user_id_relation ON /*_*/user_relationship (`r_user_id_relation`);
1717
@@ -28,6 +28,6 @@
2929 `ur_type` int(2) default NULL,
3030 `ur_message` varchar(255) default NULL,
3131 `ur_date` datetime default NULL
32 -) DEFAULT CHARSET=utf8;
 32+) /*$wgDBTableOptions*/;
3333 CREATE INDEX /*i*/ur_user_id_from ON /*_*/user_relationship_request (`ur_user_id_from`);
3434 CREATE INDEX /*i*/ur_user_id_to ON /*_*/user_relationship_request (`ur_user_id_to`);
Index: trunk/extensions/SocialProfile/UserSystemMessages/user_system_messages.sql
@@ -5,5 +5,5 @@
66 `um_message` varchar(255) NOT NULL default '',
77 `um_type` int(5) default '0',
88 `um_date` datetime default NULL
9 -) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 9+) /*$wgDBTableOptions*/;
1010 CREATE INDEX /*i*/up_user_id ON /*_*/user_system_messages (`um_user_id`);
Index: trunk/extensions/SocialProfile/UserGifts/usergifts.sql
@@ -9,7 +9,7 @@
1010 `ug_type` int(2) default NULL,
1111 `ug_message` varchar(255) default NULL,
1212 `ug_date` datetime default NULL
13 -) ENGINE=InnoDB;
 13+) /*$wgDBTableOptions*/;
1414 CREATE INDEX /*i*/ug_user_id_from ON /*_*/user_gift (`ug_user_id_from`);
1515 CREATE INDEX /*i*/ug_user_id_to ON /*_*/user_gift (`ug_user_id_to`);
1616
@@ -22,4 +22,4 @@
2323 `gift_description` text,
2424 `gift_given_count` int(5) default '0',
2525 `gift_createdate` datetime default NULL
26 -) ENGINE=InnoDB;
\ No newline at end of file
 26+) /*$wgDBTableOptions*/;
\ No newline at end of file

Status & tagging log