r98049 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98048‎ | r98049 | r98050 >
Date:02:09, 25 September 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r96717; Fix whitespace.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/json/ServicesJsonTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/json/ServicesJsonTest.php
@@ -63,7 +63,7 @@
6464 array( '♥ü', 'unicode string test' ),
6565 array( array( 'some', 'string', 'values' ), 'basic array of strings' ),
6666 array( array( 'key1' => 'val1', 'key2' => 'val2' ), 'array with string keys' ),
67 - array( array( 1 => 'val1', 3 => 'val2', '2' => 'val3' ), 'out of order numbered array test' ),
 67+ array( array( 1 => 'val1', 3 => 'val2', '2' => 'val3' ), 'out of order numbered array test' ),
6868 array( array(), 'empty array test' ),
6969 array( $obj, 'basic object test' ),
7070 array( new stdClass, 'empty object test' ),
@@ -73,21 +73,21 @@
7474
7575 function provideValuesToDecode() {
7676 return array(
77 - array( '1', 'basic integer' ),
78 - array( '-1', 'negative integer' ),
79 - array( '1.1', 'basic float' ),
80 - array( '1.1e1', 'scientific float' ),
81 - array( 'true', 'basic bool true' ),
82 - array( 'false', 'basic bool false' ),
83 - array( '"some string"', 'basic string test' ),
84 - array( '"some string\nwith newline"', 'newline string test' ),
85 - array( '"♥ü"', 'unicode character string test' ),
86 - array( '"\u2665"', 'unicode \\u string test' ),
87 - array( '["some","string","values"]', 'basic array of strings' ),
88 - array( '[]', 'empty array test' ),
 77+ array( '1', 'basic integer' ),
 78+ array( '-1', 'negative integer' ),
 79+ array( '1.1', 'basic float' ),
 80+ array( '1.1e1', 'scientific float' ),
 81+ array( 'true', 'basic bool true' ),
 82+ array( 'false', 'basic bool false' ),
 83+ array( '"some string"', 'basic string test' ),
 84+ array( '"some string\nwith newline"', 'newline string test' ),
 85+ array( '"♥ü"', 'unicode character string test' ),
 86+ array( '"\u2665"', 'unicode \\u string test' ),
 87+ array( '["some","string","values"]', 'basic array of strings' ),
 88+ array( '[]', 'empty array test' ),
8989 array( '{"key":"value"}', 'Basic key => value test' ),
9090 array( '{}', 'empty object test' ),
91 - array( 'null', 'null test' ),
 91+ array( 'null', 'null test' ),
9292 );
9393 }
9494 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96717Add some other ServicesJson tests.dantman07:15, 10 September 2011

Status & tagging log